Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarkus.liquibase.default-schema-name fixed at build time #37649

Open
An1s9n opened this issue Dec 11, 2023 · 5 comments
Open

quarkus.liquibase.default-schema-name fixed at build time #37649

An1s9n opened this issue Dec 11, 2023 · 5 comments

Comments

@An1s9n
Copy link

An1s9n commented Dec 11, 2023

Describe the bug

Starting with version 3.5.2 it looks like quarkus.liquibase.default-schema-name configuration property is fixed at build time when running in native mode. In 3.5.1 and below works as expected

Expected behavior

Native image is built with quarkus.liquibase.default-schema-name property set to public. When you run app with mentioned property overridden with foo then tables are created in foo schema

Actual behavior

Native image is built with quarkus.liquibase.default-schema-name property set to public. When you run app with mentioned property overridden with foo then tables are created in public schema, which is not expected

How to Reproduce?

To be added later if needed

Output of uname -a or ver

Darwin 192.168.1.51 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct 9 21:28:45 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T6020 arm64 (same behavior on our Linux server)

Output of java -version

openjdk version "17.0.7" 2023-04-18 LTS OpenJDK Runtime Environment Zulu17.42+19-CA (build 17.0.7+7-LTS) OpenJDK 64-Bit Server VM Zulu17.42+19-CA (build 17.0.7+7-LTS, mixed mode, sharing)

Mandrel or GraalVM version (if different from Java)

No response

Quarkus version or git rev

3.5.2

Build tool (ie. output of mvnw --version or gradlew --version)

Gradle 8.5

Additional information

No response

@An1s9n An1s9n added area/native-image kind/bug Something isn't working labels Dec 11, 2023
Copy link

quarkus-bot bot commented Dec 11, 2023

/cc @Karm (mandrel), @andrejpetras (liquibase), @galderz (mandrel), @geoand (liquibase), @gsmet (liquibase), @zakkak (mandrel)

@geoand
Copy link
Contributor

geoand commented Dec 11, 2023

That's odd, I don't see any changes in the Liquibase extension itself.

If you can provide a simple project that reproduces the issue, it would be a great help in nailing down what causes this.

Thanks

@geoand geoand added the triage/needs-reproducer We are waiting for a reproducer. label Dec 11, 2023
@An1s9n
Copy link
Author

An1s9n commented Dec 14, 2023

Hi, @geoand! I've prepared a reproducer here

Let me also share my findings during reproducer preparation, hope it would help you to find the root of the problem

If I override property directly, for example quarkus.liquibase.default-schema-name then everything works fine. But if in resources/application.yaml I use a placeholder like this: quarkus.liquibase.default-schema-name: ${datasource.schema} and try to override datasource.schema then it fails

One more fact: I managed to reproduce it only with Gradle. Maven works just fine

Once again, all this starts with 3.5.2 version

@geoand
Copy link
Contributor

geoand commented Dec 15, 2023

One more fact: I managed to reproduce it only with Gradle. Maven works just fine
Once again, all this starts with 3.5.2 version

Thanks!

@aloubyansky @radcortez are you aware of any Gradle and / or config changes that appeared in 3.5.2 that could have affected this?

@geoand geoand removed the triage/needs-reproducer We are waiting for a reproducer. label Dec 15, 2023
@radcortez
Copy link
Member

Maybe these are related?

#37021
#37273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants