Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing tool for Dev UI doesn't allow testing JSON-RPC methods that take non-string arguments #37481

Closed
jmartisk opened this issue Dec 4, 2023 · 1 comment · Fixed by #37511
Closed

Testing tool for Dev UI doesn't allow testing JSON-RPC methods that take non-string arguments #37481

jmartisk opened this issue Dec 4, 2023 · 1 comment · Fixed by #37511
Assignees
@phillip-kruger
Labels
area/dev-ui kind/bug Something isn't working
Milestone
3.7.0.CR1

Comments

@jmartisk
Copy link
Contributor

jmartisk commented Dec 4, 2023

Describe the bug

Params to JSON-RPC methods can only be passed in a Map<String, String> so this is only applicable to methods that take String arguments: https://github.com/quarkusio/quarkus/blob/3.6.0/extensions/vertx-http/dev-ui-tests/src/main/java/io/quarkus/devui/tests/DevUIJsonRPCTest.java#L62 - when you want to pass something else, there is no way to do it.

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response
@jmartisk jmartisk added the kind/bug Something isn't working label Dec 4, 2023
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Dec 4, 2023

/cc @cescoffier (devui)

@jmartisk jmartisk changed the title Testing tool for Dev UI doesn't allow testing JSON-RPC methods that takes non-string arguments Testing tool for Dev UI doesn't allow testing JSON-RPC methods that take non-string arguments Dec 4, 2023
@phillip-kruger phillip-kruger mentioned this issue Dec 5, 2023
Merged
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phillip-kruger phillip-kruger

Labels
area/dev-ui kind/bug Something isn't working
Projects
None yet
Milestone
3.7.0.CR1
Development

Successfully merging a pull request may close this issue.

Add more parameter types in Dev UI JsonRPC Tests phillip-kruger/quarkus
2 participants
@jmartisk @phillip-kruger