-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: security-oidc-bearer-token-authentication-tutorial guide #37404
Comments
/cc @pedroigor (bearer-token,oidc), @sberyozkin (bearer-token,oidc,security) |
@jedla97 Thanks for the review,
I agree, I'm not too keen on retaining this style
Please open an independent issue, it is generated and is not controlled at the individual guide level. Re points 6-8 - I'll try to clarify a few details, but I'll probably won't be changing the order of sections now, it is a typical flow observed across many tutorials.
Given this comment I believe it is quite clear how it should be tested, thanks |
@jedla97 I've started working on the PR |
@jedla97 I'm opening a PR now, here are the changes given your comments:
Fixed it
As mentioned above, it pulled in transitively
Might be a localbuild related, if I click
Fixed for this guide and will continue in other guides
Fixed, the template used right now does not resolve correctly
IMHO it is not necessary, there is only Introduction before that section in that doc
The configuration example in this tutorial just above where
So IMHO all is clear here.
IMHO it is all very precise here: |
@sberyozkin Thanks for addressing the problem or explain them! For the keycloak I found out why it was not loaded for me. It was that quickstart have it in config directory so I put it there also but not add it as resources in pom. |
Describe the bug
Going through the security-oidc-bearer-token-authentication-tutorial guide I found some issues.
.1. Headline
.quarkus-resteasy-reactive
should be added. Quickstart usingquarkus-resteasy-reactive-jackson
.Using Gradle (build.gradle):
is there but missing text. There should be equivalent of maven pom added extension.keycloak.version
should be probably updated. It's recommend 17.0.0+ but now 22.x and 23.x versions are based on Quarkus 3.x. It would be nice to bump it little. I tested it with 17.0.0 and the guide is work fine but there is possible in more complex scenarios it can fail using older Keycloak. I search through source code and the 17.0.0+ is in more guides.- Keycloak link to
creating a new realm
should be https://www.keycloak.org/docs/latest/server_admin/index.html#proc-creating-a-realm_server_administration_guide-
Quarkus Keycloak Admin Client
should be https://quarkus.io/version/main/guides/security-keycloak-admin-client-
Dev Services for Keycloak
link to should be https://quarkus.io/version/main/guides/security-openid-connect-dev-services-
Dev UI
should be https://quarkus.io/version/main/guides/dev-ui- In references maybe the
Dev Services for Keycloak
should point out at https://quarkus.io/version/main/guides/security-openid-connect-dev-services#dev-services-for-keycloak/api/admin
or/api/users/me
but it not clear where or how. It can be tested in dev-ui login and test the different paths there or it can be tested by curl. For me first thing was put it in browser and try it. But we need token to access with specific user. This is mentioned in testing section. My personal take is that the order of procedure should be like this (using all the procedures mentioned in guide)- 1. Create the Maven project
- 2. Write the application
- 3. Configure the application
- 4. Run the application in dev mode
- 5. Test the application
- 6. Start and configure the Keycloak server
- 7. Run the Application in JVM mode
- 8. Run the application in native mode
The order is my personal take but I definitely wouldn't put Start and configuration of Keycloak before devmode as we need it only with JVM and native mode. For the testing reason is mentioned above. Or it can be last but there it should be something in devmode section how to test it (for example link to testing section)
Expected behavior
No response
Actual behavior
No response
How to Reproduce?
No response
Output of
uname -a
orver
No response
Output of
java -version
No response
Quarkus version or git rev
No response
Build tool (ie. output of
mvnw --version
orgradlew --version
)No response
Additional information
No response
The text was updated successfully, but these errors were encountered: