Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ManagedBeanTypesTest#testGenericHierarchyBeanTypes not compatible with Java 21 #36632

Closed
gsmet opened this issue Oct 23, 2023 · 9 comments
Closed
Labels
area/arc Issue related to ARC (dependency injection)

Comments

@gsmet
Copy link
Member

gsmet commented Oct 23, 2023

Making progress on Java 21 CI and stumbled upon this problem (see SequencedCollection):

[ERROR] ManagedBeanTypesTest>Arquillian.run:138->testGenericHierarchyBeanTypes:80 Set [class java.lang.Object, java.util.List<org.jboss.cdi.tck.tests.definition.bean.types.Vulture<java.lang.Integer>>, java.util.SequencedCollection<org.jboss.cdi.tck.tests.definition.bean.types.Vulture<java.lang.Integer>>, java.lang.Iterable<org.jboss.cdi.tck.tests.definition.bean.types.Vulture<java.lang.Integer>>, java.util.Collection<org.jboss.cdi.tck.tests.definition.bean.types.Vulture<java.lang.Integer>>, class org.jboss.cdi.tck.tests.definition.bean.types.Flock] (6) does not match array [class java.lang.Object, class org.jboss.cdi.tck.tests.definition.bean.types.Flock, java.util.List<org.jboss.cdi.tck.tests.definition.bean.types.Vulture<java.lang.Integer>>, java.util.Collection<org.jboss.cdi.tck.tests.definition.bean.types.Vulture<java.lang.Integer>>, java.lang.Iterable<org.jboss.cdi.tck.tests.definition.bean.types.Vulture<java.lang.Integer>>] (5)

We are using the latest version of the CDI TCK, 4.0.12. Is there any plan to make the TCK compatible with Java 21 or should we skip this test?

@gsmet gsmet added area/arc Issue related to ARC (dependency injection) and removed triage/needs-triage labels Oct 23, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 23, 2023

/cc @Ladicek (arc), @manovotn (arc), @mkouba (arc)

@manovotn
Copy link
Contributor

This was one of the two reasons to release 4.0.12 TCK IIRC, let me check...

@gsmet
Copy link
Member Author

gsmet commented Oct 23, 2023

I checked and we are using 4.0.12 so not sure what's going on.

@manovotn
Copy link
Contributor

Right, here is the TCK challenge - jakartaee/cdi-tck#485
And the test was then excluded for 4.0 version (and fixed for the upcoming 4.1), see https://github.com/jakartaee/cdi-tck/blob/4.0.12/impl/src/main/resources/tck-tests.xml#L53-L58

But we don't seem to be using same excusion list, instead we have https://github.com/quarkusio/quarkus/blob/main/tcks/jakarta-cdi/src/test/resources/testng.xml
So I guess we need to copy the exclusion into our our list.

@gsmet
Copy link
Member Author

gsmet commented Oct 23, 2023

   mvn dependency:tree | grep tck
[INFO] -----------------< io.quarkus.arc:arc-cdi-tck-runner >------------------
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ arc-cdi-tck-runner ---
[INFO] io.quarkus.arc:arc-cdi-tck-runner:jar:999-SNAPSHOT
[INFO] +- io.quarkus.arc:arc-cdi-tck-porting-pkg:jar:999-SNAPSHOT:compile
[INFO] |  \- jakarta.enterprise:cdi-tck-api:jar:4.0.12:compile
[INFO] \- jakarta.enterprise:cdi-tck-core-impl:jar:4.0.12:compile
[INFO]    +- jakarta.enterprise:cdi-tck-ext-lib:jar:4.0.12:compile

Now, maybe the tests are coming from somewhere else?

@gsmet
Copy link
Member Author

gsmet commented Oct 23, 2023

@manovotn thanks, will handle it in my branch then.

@manovotn
Copy link
Contributor

@manovotn thanks, will handle it in my branch then.

No problem. We might as well do it in the main branch to have the two lists synced.
Note however that the TCK list I linked includes CDI Full tests that we aren't running - which is probably a reason why we have our own.

@gsmet
Copy link
Member Author

gsmet commented Oct 23, 2023

I added a commit there: #36284 .

Thanks for the quick feedback.

@gsmet gsmet closed this as completed Oct 23, 2023
@gsmet
Copy link
Member Author

gsmet commented Oct 23, 2023

No problem. We might as well do it in the main branch to have the two lists synced.

I confirm my PR targets the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Development

No branches or pull requests

2 participants