Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting base image layer and application layer cache in Jib build #36379

Closed
elendis opened this issue Oct 10, 2023 · 5 comments · Fixed by #38206
Closed

Setting base image layer and application layer cache in Jib build #36379

elendis opened this issue Oct 10, 2023 · 5 comments · Fixed by #38206
Labels
area/cache area/container-image kind/enhancement New feature or request
Milestone
3.7.0.CR1

Comments

@elendis
Copy link
Contributor

elendis commented Oct 10, 2023

Description

The Jib Containerizer allows configuration of the base image layer cache and the application layers cache.

Would it be possible to allow setting these values when building via Quarkus?

We would like move these caches to a different folder on our CI system.

Implementation ideas

Add corresponding ConfigItems to ContainerImageJibConfig and use the values (if set) when creating the com.google.cloud.tools.jib.api.Containerizer in JibProcessor#createContainerizer.
@elendis elendis added the kind/enhancement New feature or request label Oct 10, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 10, 2023

/cc @geoand (jib), @gwenneg (cache)

@geoand
Copy link
Contributor

geoand commented Oct 10, 2023

Sounds perfectly reasonable.

Would you like to provide a PR adding this feature?

@elendis
Copy link
Contributor Author

elendis commented Oct 10, 2023

Sure, I can give it a go :-) This will be my first open source contribution and there is some admin stuff to sort out with my employer, so this might take a moment though...

@geoand
Copy link
Contributor

geoand commented Oct 10, 2023

No problem!

Let us know if you need any help

@elendis elendis mentioned this issue Jan 15, 2024
Merged
@elendis
Copy link
Contributor Author

elendis commented Jan 15, 2024

Just created a PR for this, if anythings missing or needs to be changed let me know!

@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/cache area/container-image kind/enhancement New feature or request
Projects
None yet
Milestone
3.7.0.CR1
Development

Successfully merging a pull request may close this issue.

Add configurations for base image layer and application layer cache in Jib build
2 participants
@elendis @geoand