Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openshift local ImageStream lookup only works for single segment images. #34748

Closed
iocanel opened this issue Jul 14, 2023 · 1 comment · Fixed by #34962
Closed

Openshift local ImageStream lookup only works for single segment images. #34748

iocanel opened this issue Jul 14, 2023 · 1 comment · Fixed by #34962
Milestone

Comments

@iocanel
Copy link
Contributor

iocanel commented Jul 14, 2023

Describe the bug

According to Using ImageStrems with Kubneretes resources locaI ImageStream lookup requires single segment images.

We should enforce that when its possible and log a warnining when not.

When to enforce:

  • Deployment kind not DeploymentConfig.
  • No registry has been specified.
  • No image group has been explicitly specifed.
  • No image has been explicitly specified.

Implementation ideas

At first glance this seems trivial however, it can be really tricky as its not just a matter of setting image on Deployment.
Why?
Becasue we may use the same image elsewhere (e.g. Job for initialization tasks).

So, it's important to fix this at the ImageInfoBuildItem. level.
But this will require the container image extension to know about our deployment target.
So, we will most likely need to create a new spi build item for cases where we need single segment images.

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@iocanel iocanel added the kind/bug Something isn't working label Jul 14, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 14, 2023

/cc @geoand (openshift)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants