-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubernetes name influenced by the quarkus.container-image.name
#33554
Comments
I just added the service account, but it's the case for all the names used in my generated descriptor. |
It seems as if intended, though out of context it doesn't really make much sense: Line 48 in 4118dcc
Need to get back and see why this was added. |
The change was introduced in #7396 in an effort to reduce the need of copying group, image, version among (container image, kubernetes, openshift & knative config). While the idea is not bad, it certaintly can get confusing. It took more than a quick glance to realize it was intended. So 🤷 |
Hum... still confusing. |
I agree with @cescoffier : one thing is the container name and another thing the application name. The application name does make sense to be equal to the name of the generated resources. |
Yeah, I guess we should change it |
Awesome! Thanks! |
Describe the bug
I have an application. It sets the image name to quarkus.container-image.name=hide-and-seek-${quarkus.application.name}. I didn't expect this to change the name in my kubernetes descriptor:
According to @iocanel it's not intended and it's a bug
Expected behavior
Setting
quarkus.container-image.name
should not change the kubernetes names.Actual behavior
Setting
quarkus.container-image.name
is used in my kubernetes descriptor (for the names)How to Reproduce?
No response
Output of
uname -a
orver
No response
Output of
java -version
No response
GraalVM version (if different from Java)
No response
Quarkus version or git rev
No response
Build tool (ie. output of
mvnw --version
orgradlew --version
)No response
Additional information
No response
The text was updated successfully, but these errors were encountered: