Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Livereload doesn't work for AMQP reactive messaging #3347

Closed
loicmathieu opened this issue Jul 26, 2019 · 7 comments
Closed

Livereload doesn't work for AMQP reactive messaging #3347

loicmathieu opened this issue Jul 26, 2019 · 7 comments
Labels
kind/enhancement New feature or request pinned Issue will never be marked as stale triage/duplicate This issue or pull request already exists

Comments

@loicmathieu
Copy link
Contributor

Describe the bug
I follow the AMQP guide (https://quarkus.io/guides/amqp-guide) and the livereload was not working. When I update one of my classes I need to restart Quarkus.

Expected behavior
Livereload avoid restarting Quarus for each source modification.

To Reproduce
Steps to reproduce the behavior:

  1. Follow the guide
  2. Send a message (I use Artemis admin console to send a message)
  3. Update one source file
  4. Send a message

Configuration

# Configures the AMQP broker credentials.
amqp-username=quarkus
amqp-password=quarkus

# Configure the AMQP connector to read from the `carte-cadeau-creation` queue
mp.messaging.incoming.carte-cadeau-creation.connector=smallrye-amqp
mp.messaging.incoming.carte-cadeau-creation.durable=true

# Configure the AMQP connector to read from the `carte-cadeau-transaction` queue
mp.messaging.incoming.carte-cadeau-transaction.connector=smallrye-amqp
mp.messaging.incoming.carte-cadeau-transaction.durable=true

Environment (please complete the following information):

@loicmathieu loicmathieu added the kind/bug Something isn't working label Jul 26, 2019
@geoand
Copy link
Contributor

geoand commented Aug 10, 2019

Last I knew, this was expected (since the live-reload is triggered on incoming http requests). @stuartwdouglas, @cescoffier has anything changed in that area?

@loicmathieu
Copy link
Contributor Author

@geoand I saw that a PR will provides hot replacements for kafka-stream (#3500) so if a messaging technology provides live reload I think all should provides it.

@gsmet
Copy link
Member

gsmet commented Aug 26, 2019

Sure, that would be the ultimate goal. But for now, I think only HTTP and soon Kafka Streams are supported.

@gsmet gsmet added kind/enhancement New feature or request and removed kind/bug Something isn't working labels Aug 26, 2019
@geoand
Copy link
Contributor

geoand commented Aug 26, 2019

Yeah, the live reload for Kafka looks really Kafka specific at this point

@stale
Copy link

stale bot commented Nov 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you!
We are doing this automatically to ensure out-of-date issues does not stay around indefinitely.
If you believe this issue is still relevant please put a comment on it on why and if it truly needs to stay request or add 'pinned' label.

@stale stale bot added the stale label Nov 13, 2019
@loicmathieu
Copy link
Contributor Author

I still think that we should provides live reload for all reactive messaging implementation: AMQP, MQTT and Kafka.

@stale stale bot removed the stale label Nov 13, 2019
@gsmet gsmet added the pinned Issue will never be marked as stale label Nov 13, 2019
@gsmet
Copy link
Member

gsmet commented Nov 18, 2019

I generalized this older issue for reactive messaging: #3217 .

Closing this one as duplicate.

@gsmet gsmet closed this as completed Nov 18, 2019
@gsmet gsmet added the triage/duplicate This issue or pull request already exists label Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request pinned Issue will never be marked as stale triage/duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants