NullPointerExeception when running quarkus:dev when trying to write dynamic property from git-commit-id-maven-plugin to manifest #32816
Labels
Milestone
Comments
|
/cc @quarkusio/devtools (maven) |
|
Does it change if you add a |
|
It depends where the git-commit-id plugin is defined in de pom.
This is because Using My initial issue still stands though. Running |
This was referenced May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Hello,
I am trying to add the current git commit id to the MANIFEST.MF of the quarkus build artifact.
In the past I have used
git-commit-id-maven-pluginto extract this value into a maven property:and add the property
git.commit.id.describeto the jar file using themaven-jar-pluginwith:Now from what I understand, with Quarkus I can no longer use the
maven-jar-pluginbut have to use thequarkus-maven-pluginto set manifest values:When running the project with
mvn quarkus-dev(or in my case form intellij with the quarkus plugin), I get a NullPointerException on parsing properties and the application does not start.Expected behavior
When building the project with
mvn clean package -DskipTests=true, I expect to find in the quarkus-run.jar MANIFEST.MF fileImplementation-Build: [my.git.commit.id]When running the project with
mvn quarkus-dev(or in my case form intellij with the quarkus plugin), I expect the application to startActual behavior
When building the project with
mvn clean package -DskipTests=true, I find in the quarkus-run.jar MANIFEST.MF fileImplementation-Build: [my.git.commit.id]When running the project with
mvn quarkus-dev(or in my case form intellij with the quarkus plugin), I get:How to Reproduce?
Steps to reproduce the behavior:
git-commit-id-maven-pluginto the pomquarkus-maven-pluginmvn quarkus:devOutput of
uname -aorverMicrosoft Windows [Version 10.0.22621.1555]
Output of
java -versionopenjdk version "17.0.5" 2022-10-18 OpenJDK Runtime Environment Temurin-17.0.5+8 (build 17.0.5+8) OpenJDK 64-Bit Server VM Temurin-17.0.5+8 (build 17.0.5+8, mixed mode, sharing)
GraalVM version (if different from Java)
No response
Quarkus version or git rev
2.16.6
Build tool (ie. output of
mvnw --versionorgradlew --version)Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) Maven home: C:\dev\tools\maven\apache-maven-3.8.6 Java version: 17.0.5, vendor: Eclipse Adoptium, runtime: C:\dev\tools\jdk\adoptium\jdk-17.0.5+8 Default locale: en_US, platform encoding: Cp1252 OS name: "windows 11", version: "10.0", arch: "amd64", family: "windows"
Additional information
${git.commit.id.describe}from themanifestEntriesthe application works with quarkus:dev, but I do not get the Implementation-Build entry in the manifest.${git.commit.id.describe}to the maven<properties>, the application works with quarkus:dev, but then the value is static and it is not overwritten by thegit-commit-id-maven-pluginduring build.mvn compile quarkus:dev, the application works, but the intellij plugin does not use this. It likely works as thecompilephase triggers thegit-commit-id-maven-pluginto set its properties in the reactor.${git.commit.id.describe}is set dynamically by thegit-commit-id-maven-plugin.It seems as if the
git-commit-id-maven-pluginis not run when runningquarkus:dev, or the properties are not copied the reactor. It is as if thequarkus:devgoal does not use the rest of maven at all (seeing how the maven-jar-plugin also is not used).I am stuck on how to make both these scenarios work at the same time. I am happy to solve this problem in another way, with a different plugin or setting in maven.
The text was updated successfully, but these errors were encountered: