Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quartz configuration useProperties in application.properties file #30834

Closed
FelixA opened this issue Feb 3, 2023 · 4 comments · Fixed by #33534
Closed

Quartz configuration useProperties in application.properties file #30834

FelixA opened this issue Feb 3, 2023 · 4 comments · Fixed by #33534
Assignees
Labels
Milestone

Comments

@FelixA
Copy link

FelixA commented Feb 3, 2023

Describe the bug

It seems that it is not possible to configure the quartz property useProperties in Quarkus

The Quartz documentation provides a property called "org.quartz.jobStore.useProperties"

According to the quarkus quartz documentation, this property is not configurable. Actually, the QuartzSchedulerImpl is setting this value hardcoded to true for every dbStore-Type even though the quartz documentation default-value is false.

I wonder if there is any reason to not make this property configurable, since we need the ability to store blob values in the database.

Expected behavior

Extend the Quarkus Quartz config to be able to override the property "org.quartz.jobStore.useProperties"

Actual behavior

According to the QuartzSchedulerImpl class it seems that for non-DB store configuration the property will default to false,
whereas for any dbStore type the property is set to true.

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

Apparently, when using the graalvm due to oracle/graal#460 the property has to be set to true. Yet we are using the JVM and need the ability to set the property.

@FelixA FelixA added the kind/bug Something isn't working label Feb 3, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 3, 2023

/cc @machi1990 (quartz), @mkouba (quartz)

@mkouba mkouba added kind/enhancement New feature or request and removed kind/bug Something isn't working labels Feb 3, 2023
@geoand geoand changed the title Quartz configuration useProperties in application.properties file #24105 Quartz configuration useProperties in application.properties file Feb 3, 2023
@machi1990
Copy link
Member

Apparently, when using the graalvm due to oracle/graal#460 the property has to be set to true. Yet we are using the JVM and need the ability to set the property.

The reason why this property is not configurable was that back in the days it didn't work for native image and we wanted to have a consistent working behavior between JVM mode and native image.
Over the recent graalvm release, serialiazation is supported and maybe we could evaluate exposing this property again depending on how far/stable serialization support is in native image.

@machi1990
Copy link
Member

Worth noting that, once we've the #24636 PR in, it'll be possible to have this sort of customization

@machi1990
Copy link
Member

I've opened #33534 to allow configuring the use of properties or not. The configuration know will be quarkus.quartz.serialize-job-data which can be either true or false. The default is false which will equate to useProperties=true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants