Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring the port for the http probe #30547

Closed
iocanel opened this issue Jan 23, 2023 · 3 comments · Fixed by #30566
Closed

Allow configuring the port for the http probe #30547

iocanel opened this issue Jan 23, 2023 · 3 comments · Fixed by #30566
Assignees
Labels
Milestone

Comments

@iocanel
Copy link
Contributor

iocanel commented Jan 23, 2023

Description

Currently, there is no configuration option for setting the port of the httpAction for probes. The port number is infered from the build system, by looking up for a port named http.

There are cases where we need to use another port (e.g. the management port). We should provide the option in PortConfig to use a differnet port name or value.

Implementation ideas

No response

@iocanel iocanel added the kind/enhancement New feature or request label Jan 23, 2023
@cescoffier
Copy link
Member

The config could be either an int or a string (port binding name).

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 23, 2023

/cc @Sgitario (kubernetes), @geoand (knative,kubernetes,minikube,openshift)

@iocanel
Copy link
Contributor Author

iocanel commented Jan 23, 2023

We should probide the option in PortConfig to use a differnet port name or value

probide ?

This is a typo, no pun intended!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants