Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP access log contains duplicate entries when rerouting requests #30105

Closed
brahim-raddahi opened this issue Dec 30, 2022 · 3 comments
Closed
Labels
area/vertx kind/bug Something isn't working triage/needs-reproducer We are waiting for a reproducer.

Comments

@brahim-raddahi
Copy link

Describe the bug

When using a RouteFilter to reroute requests, the access log handler seems to be added multiple times, resulting in multiple lines for the same request in the access log.

This:
https://github.com/quarkusio/quarkus/blob/3.0.0.Alpha2/extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/filters/accesslog/AccessLogHandler.java#L145

Should only be triggered once per RoutingContext

Sidenote: there does not seem to be an option to refer to the "original request" variables vs the rewritten ones (Apache uses ">" and "<" for this), the logged path for example will be the rewritten/rerouted one

Expected behavior

The access log should contain only one line per request

Actual behavior

The access log contains multiple lines per request

How to Reproduce?

Add a RouteFilter to your application: https://quarkus.io/guides/reactive-routes#intercepting-http-requests
In that RouteFilter -> reroute the request: rc.reroute(...)
Enable the http access log: https://quarkus.io/guides/http-reference#configuring-http-access-logs

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@brahim-raddahi brahim-raddahi added the kind/bug Something isn't working label Dec 30, 2022
@geoand
Copy link
Contributor

geoand commented Jan 3, 2023

Can you please provide a sample application that behaves the way you describe?

@geoand geoand added the triage/needs-reproducer We are waiting for a reproducer. label Jan 3, 2023
@geoand
Copy link
Contributor

geoand commented Feb 2, 2023

Closing as we never got feedback

@geoand geoand closed this as not planned Won't fix, can't repro, duplicate, stale Feb 2, 2023
@brahim-raddahi
Copy link
Author

Sorry for the late response, I opened a new issue which contains code required to reproduce this: #30845

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertx kind/bug Something isn't working triage/needs-reproducer We are waiting for a reproducer.
Projects
None yet
Development

No branches or pull requests

3 participants