-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenTelemetry instrumentation stops working for resteasy-reactive resources and JDBC after dev mode reload #29645
Comments
@brunobat weren't you working on something related? |
There is a PR for it: #28792 |
Nice, thanks! |
@famod is it a regression in 2.14? I'm wondering if I should backport it for the next 2.14 (planned for tomorrow). |
No. It never worked :) |
It's a rather confusing issue. First thing you probably do when you're new to OTEL is to play around with it in dev mode. So after a reload you are faced with partially broken tracing and as a newbie you start looking for your own mistakes (but there are none here). |
Describe the bug
OTEL instrumentation seems to stop working for resteasy-reactive resources and JDBC calls when dev mode is reloaded (manually or due to a file change).
The reproducer further down demonstrates that via the logged MDC values, but it is not a mere MDC issue.
I first found this issue on my local Jaeger instance. I was missing some traces and spans and instead I got some unexpected traces that are supposed to be sub-spans of traces.
I also didn't see any JDBC sub-spans in my
@Scheduled
traces anymore (see also #28552 (comment)).Expected behavior
Traces are generated just like before the dev mode reload
Actual behavior
No proper traces are generated anymore after dev mode reload
How to Reproduce?
s
in dev mode (or change a file and call/hello
)Note: This quickstart is a bit sparse ATM, see also: quarkusio/quarkus-quickstarts#1120
Output of
uname -a
orver
No response
Output of
java -version
No response
GraalVM version (if different from Java)
No response
Quarkus version or git rev
2.14.2
Build tool (ie. output of
mvnw --version
orgradlew --version
)No response
Additional information
Another user had the same issue a few months back: #26804 (comment)
It's worth stressing that bean methods annotated with
@WithSpan
are still working after reload, but obviously, if those calls are sub-spans of REST calls they are shown as separate traces in Jaeger as there is no parent trace anymore.The text was updated successfully, but these errors were encountered: