Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry Collector for DevServices #26445

Closed
radcortez opened this issue Jun 29, 2022 · 12 comments · Fixed by #38448
Closed

OpenTelemetry Collector for DevServices #26445

radcortez opened this issue Jun 29, 2022 · 12 comments · Fixed by #38448
Assignees
Labels
area/devservices area/tracing kind/enhancement New feature or request kind/epic Large issue with links to sub-issues
Milestone

Comments

@radcortez
Copy link
Member

radcortez commented Jun 29, 2022

Description

When the OpenTelemetry Extension is available, provide an OpenTelemetry collector as a DevService to collect Spans.

Implementation ideas

[Epic waiting for design]

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 29, 2022

/cc @stuartwdouglas

@kdubb
Copy link
Contributor

kdubb commented Jul 1, 2022

+1000

Just yesterday I was wishing for the ability to see my telemetry in the Quarkus Dev UI

@jtama
Copy link
Contributor

jtama commented Oct 19, 2022

If a devservice is provided, then which receiver should be configured ? Otlp receiver only ? If micrometer-prometheus is also present, should the prometheus receiver be configured ?

@stuartwdouglas
Copy link
Member

CC @ebullient

I am pretty sure we talked about this a while back and you had some concerns?

@ebullient
Copy link
Member

Right now, we have some work to do to make sure the OTLP collector works well if both are enabled (there is an OTLP extension in quarkiverse, and that fights a bit with the OTel extension when both are present, IIRC). If we just have OTel + Micrometer/Prometheus, there are no arguments, and it is fine.

Are you suggesting embedding jaeger, kiali or some other visualization tool for the dev mode UI via testcontainers? or something else?

@radcortez
Copy link
Member Author

My initial idea was to support the OTel Collector to collect the telemetry data (considering the Micrometer will also output the metrics in OTLP). Having a way to visualize the telemetry data was also on my mind, but Jaeger is probably not the right one, since it only should trace data and I think we want something that can show both tracing, metrics and in the future logging.

@ebullient
Copy link
Member

I think the OTLP micrometer registry (which writes OTLP) conflicts with the presence of the OTel SDK: quarkiverse/quarkus-micrometer-registry#203 .. so we have something to resolve first.

@brunobat
Copy link
Contributor

brunobat commented Oct 28, 2022

My Idea here is that we should have OTel collector and be able to see traces in a devmode Graphana.
This way, we could use the same UI if metrics is also available.
This should work in an integrated way between Micrometer and Otel.

@brunobat
Copy link
Contributor

But for starters, It would be nice just to have the collector logging whatever it receives for debug purposes.

@brunobat brunobat added the kind/epic Large issue with links to sub-issues label Dec 12, 2022
@brunobat brunobat moved this from Todo to In Progress in Quarkus Roadmap/Planning Jul 5, 2023
@geoand
Copy link
Contributor

geoand commented Jul 5, 2023

This seems right a very nice addition!

Is this currently in progress? If not, are there are any blockers?

@alesj
Copy link
Contributor

alesj commented Jul 5, 2023

Is this currently in progress?

(Too) Slow progress unfortunately -- went in the wrong direction at first, then got stuck with some other work.
I did make some better progress with porting my Prometheus / VictoriaMetrics clients,
but still need to get the whole picture right when porting my poc from my sandbox project.
Plus port some existing work with Jaeger tracing devservice.

If not, are there are any blockers?

Only time (and my pto :-)).
Will resume at this full speed when back.

@geoand
Copy link
Contributor

geoand commented Jul 5, 2023

Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devservices area/tracing kind/enhancement New feature or request kind/epic Large issue with links to sub-issues
Projects
Status: Done
8 participants