Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OIDC client pluggability #22432

Closed
rkraneis opened this issue Dec 21, 2021 · 2 comments · Fixed by #36634
Closed

Improve OIDC client pluggability #22432

rkraneis opened this issue Dec 21, 2021 · 2 comments · Fixed by #36634
Assignees
Labels
area/oidc kind/enhancement New feature or request
Milestone

Comments

@rkraneis
Copy link

Description

It would be great to add some extension points to OIDC client to modify the requests it sends besides adding static headers.

Problem at hand:
We want to interface with an Oauth2 secured API that is using HTTP Message Signatures as an additional means of protection. This requires the addition of several headers, which contents are based on the actual message body. Our current workaround (result of the discussion in #22256):

In every request:

  • create the body OidcClient will create manually using OidcCommonUtils.encodeForm
  • calculate the header values
  • manually create OidcClientConfig and OidcClient; tokens will still be managed nicely when using TokensHelper
    The workaround could be a bit smarter by chedking if tokens are actually about to run out and not bothering with most of the above if they would not.

With that in mind, an extension mechanism to support HTTP Message Signatures would have access to body and headers of the request to be sent by OIDC client and would be able to modify (or at least add to) the List of headers.

Implementation ideas

No response

@rkraneis rkraneis added the kind/enhancement New feature or request label Dec 21, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 21, 2021

/cc @pedroigor, @sberyozkin

@sberyozkin sberyozkin self-assigned this Oct 23, 2023
@sberyozkin
Copy link
Member

CC @calvernaz FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/oidc kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants