Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC: abstraction layer for scopes and fields #22198

Closed
FroMage opened this issue Dec 14, 2021 · 4 comments
Closed

OIDC: abstraction layer for scopes and fields #22198

FroMage opened this issue Dec 14, 2021 · 4 comments
Labels
area/oidc kind/enhancement New feature or request

Comments

@FroMage
Copy link
Member

FroMage commented Dec 14, 2021

Description

Every damn OIDC provider has different names and scopes for the same damn things:

quarkus.oidc.authentication.scopes=openid,email,profile

quarkus.oidc.github.authentication.scopes=user:email

quarkus.oidc.microsoft.authentication.scopes=openid,email,profile

quarkus.oidc.facebook.authentication.scopes=email,public_profile
quarkus.oidc.facebook.user-info-path=https://graph.facebook.com/me/?fields=id,name,email,first_name,last_name

quarkus.oidc.apple.authentication.scopes=openid,email,name

And then they come from different places because Github and Facebook requires UserInfo, while GitHub even requires another REST call to get the email.

It would be nice to have an abstraction that we could use to specify the fields we want, such as:

# Would be nice to be able to specify settings on every tenant with *
quarkus.oidc.*.authentication.scopes=quarkus:email,quarkus:name

This would turn quarkus:* scopes into whatever provider-specific scopes and other settings required to obtain them. Extra bonus points if it also automatically turns the UserInfo fields into the proper IdToken claims such as explained in #22030

TBH, this seems like a nice-to-have and not a hard requirement.

Implementation ideas

No response

@FroMage FroMage added the kind/enhancement New feature or request label Dec 14, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 14, 2021

/cc @pedroigor, @sberyozkin

@sberyozkin
Copy link
Member

@FroMage I'm sorry, but I'd rather close this one as we have a PR under way to support the provider specific setups in a nice way

@sberyozkin
Copy link
Member

Lets deal with it as part of #20783

@FroMage
Copy link
Member Author

FroMage commented Dec 15, 2021

But that PR doesn't deal with an abstraction for scopes, I don't see how they're the same thing…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/oidc kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants