Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OIDC closes its client after a successful JWK set read when the discovery is disabled #21984

Closed
sberyozkin opened this issue Dec 7, 2021 · 1 comment · Fixed by #21986
Closed

OIDC closes its client after a successful JWK set read when the discovery is disabled #21984

sberyozkin opened this issue Dec 7, 2021 · 1 comment · Fixed by #21986
Labels
area/oidc kind/bug Something isn't working
Milestone
2.5.2.Final

Comments

@sberyozkin
Copy link
Member

Describe the bug

@FroMage has discovered this bug.

As it happens this very code is tested to verify that if the JWK set read fails when the discovery is disabled then the recovery will be attempted during the client request. And all works - because an OIDC service application is tested and once JWKs are in, nothing else is needed if no further introspection is required.

But Steph tried it for Quarkus web-app... and also recommended how to fix it

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response
@sberyozkin sberyozkin added the kind/bug Something isn't working label Dec 7, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 7, 2021

/cc @pedroigor

@quarkus-bot quarkus-bot bot added the area/oidc label Dec 7, 2021
@sberyozkin sberyozkin mentioned this issue Dec 7, 2021
Merged
@quarkus-bot quarkus-bot bot added this to the 2.6 - main milestone Dec 7, 2021
@gsmet gsmet modified the milestones: 2.6.0.CR1, 2.5.2.Final Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/oidc kind/bug Something isn't working
Projects
None yet
Milestone
2.5.2.Final
Development

Successfully merging a pull request may close this issue.

OidcProviderClient has to be closed only when getting the JWK set failed sberyozkin/quarkus
2 participants
@sberyozkin @gsmet