Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End Vert.x response before propagating mapped exception in VertxBlockingoutput #21841

Closed
pedroigor opened this issue Dec 1, 2021 · 3 comments
Labels
area/resteasy-classic area/vertx kind/bug Something isn't working triage/out-of-date This issue/PR is no longer valid or relevant

Comments

@pedroigor
Copy link
Contributor

pedroigor commented Dec 1, 2021

Describe the bug

When an exception is thrown when processing the write stream, Resteasy does not close the Vert.X response prior to propagating the exception.

This behavior might cause applications to not receive events from Vert.X (e.g.: when using a filter that adds a headers handler) because the response is not ended properly.

Similarly to when there is no data to write, the VertxBlockingoutput should make sure the response is ended.

Related to this issue #21762.

Expected behavior

Properly end the Vert.x response.

Actual behavior

Vert.x response not properly ended when an exception occurs on the write stream.

How to Reproduce?

See #21762.

Output of uname -a or ver

Linux fedora 5.14.18-200.fc34.x86_64 #1 SMP Fri Nov 12 16:48:10 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.4+

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

Resteasy classic issue.

@geoand
Copy link
Contributor

geoand commented Dec 2, 2021

Should this be closed now that #21842 is in?

@mschorsch
Copy link
Contributor

Possible reproducer: #21762 (comment)

@pedroigor
Copy link
Contributor Author

@geoand Closing, thanks.

@geoand geoand added the triage/out-of-date This issue/PR is no longer valid or relevant label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/resteasy-classic area/vertx kind/bug Something isn't working triage/out-of-date This issue/PR is no longer valid or relevant
Projects
None yet
Development

No branches or pull requests

4 participants