Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OIDC web-app logout support #21581

Closed
sberyozkin opened this issue Nov 19, 2021 · 2 comments · Fixed by #21693
Closed

Improve OIDC web-app logout support #21581

sberyozkin opened this issue Nov 19, 2021 · 2 comments · Fixed by #21693
Assignees
Labels
area/oidc kind/enhancement New feature or request
Milestone

Comments

@sberyozkin
Copy link
Member

Description

Keycloak and some other providers support RP-initiated logout - but many don't such as Auth0, Google, etc - they have their own custom ways of dealing with it.

If the logout is required but no end-session path is returned in a discovery doc - then if the user has set a logout-path property then quarkus-oidc should just delete a q_session (it does it now for RP initiated one and has also been discovered by @FroMage) and just redirect the user to the provided logout path.

In fact it can already work right now - but I believe the auto-discovery has to be disabled for a custom logout path to be taken into the consideration - so quite likely a very simple fix is needed

Implementation ideas

No response

@sberyozkin sberyozkin added kind/enhancement New feature or request area/oidc labels Nov 19, 2021
@sberyozkin sberyozkin self-assigned this Nov 19, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 19, 2021

/cc @pedroigor

@sberyozkin
Copy link
Member Author

sberyozkin commented Nov 21, 2021

@FroMage I've had a look, quarkus.oidc.end-session-path as an absolute URL will redirect to the logout endpoint even if it is not returned in the discovery doc (and remove q_session) - but I think adding an option to add some extra logout params which are not part of the RP initiated spec but understood by Google and other providers which don't implement it would help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/oidc kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant