Hibernate statistics and metrics are no longuer showing

[AchrafBelkahla]

hello,

I just migrated to quarkus 2.4.1. The metrics and statistics are no longuer displayed in console while the sql log is OK !

My "application.properties" file :

...

quarkus.hibernate-orm.database.generation=none

quarkus.hibernate-orm.log.sql=true

quarkus.hibernate-orm.statistics=true

quarkus.hibernate-orm.metrics.enabled=true

...

[quarkus-bot]

/cc @Sanne, @ebullient, @gsmet, @jmartisk, @yrodiere

[geoand]

Can you attach a sample project that was working before 2.4.1 and is no longer working with 2.4.1?

Thanks

[jmartisk]

This was intentionally introduced by #20693
I was suggesting maybe we might want to add a separate config property to enable statistics logging, but we haven't done that yet.

[geoand]

Thanks for the information @jmartisk.

[AchrafBelkahla]

@jmartisk Thank you for replying.
So if i'm getting it right, the metrics logging is now deactivated by default and can't be logged due to the changes made in
#20693 : forcing the property to false ?

@geoand You still need the sample project ? to be more specific, I was working with 2.2.3 before switching to 2.4.1

[geoand]

@geoand You still need the sample project ? to be more specific, I was working with 2.2.3 before switching to 2.4.1

Not necessary after @jmartisk's comment

[jmartisk]

Logging of statistics is deactivated right now and can't be turned on. Metrics (meaning exposing the statistics via Micrometer or SmallRye Metrics) will still work, the statistics just won't appear in the server log.
If that's a problem, we can add a config property to enable that logging (but it will be off by default).

@Sanne , it looks like your condition in #20666 (comment) was just fulfilled :)

I can prepare a PR to add the property.

[AchrafBelkahla]

@jmartisk yes please :) We rely too much on those logs.

[Sanne]

I'm still not persuaded by it but OK let's fix it since it was an existing "feature"

@AchrafBelkahla I hope you know you can also invoke getStatistics() on any org.hibernate.Session and read the statistics you're interested in, and format then or print them in any format you like?

I would generally suggest to use this approach instead.

[AchrafBelkahla]

@Sanne Well, I didn't :/
Thank you for the info and for the rapid intervention :)

[gavinking]

FTR I agree with Sanne. I don't think statistics really belong in the log. At least, except for something the user is really especially interested in, enough to log it themself.

[klezovics]

@Sanne

I hope you know you can also invoke getStatistics() on any org.hibernate.Session

Hi ! Thank you for this comment !
I have a follow up question ... I am using PanacheRepository with Quarkus.
And I am doing a load test for which I need to collect statistic.

I can @Inject an entityManager and my xxxRepository class. How do I get the session, which is used by my xxxRepository class to get the statistics out of it.

[Sanne]

The Panache repository is using the same EntityManager that you'd get by injecting it, as it will look it up via CDI from the same context.

You can also use Panache.getEntityManager() if there is a single persistence unit, or you can use Panache.getEntityManager(Clazz) to get the one managing that specific type if you need to manage ambiguity.