Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MultiPart form result in Resteasy Reactive #21009

Closed
andreas-eberle opened this issue Oct 26, 2021 · 4 comments · Fixed by #21038
Closed

Support MultiPart form result in Resteasy Reactive #21009

andreas-eberle opened this issue Oct 26, 2021 · 4 comments · Fixed by #21038
Labels
area/rest kind/enhancement New feature or request
Milestone

Comments

@andreas-eberle
Copy link
Contributor

andreas-eberle commented Oct 26, 2021

Describe the bug

It seems resteasy reactive cannot return a multipart body. In the reproducer below, I have a method like this

	@GET
	@Path("/multipart")
	@Produces(MediaType.MULTIPART_FORM_DATA)
	public MultipartDto getMultipart() throws IOException {
		File file = File.createTempFile("abc", "txt");

		var writer = new FileWriter(file);
		writer.write("Test ABC");
		writer.close();

		return new MultipartDto("test text", file);
	}

But when I call it, I only get the following body:

org.acme.MultipartDto@345fa2e

Expected behavior

Return a correct multipart form data response

Actual behavior

Only toString of the returned object is returned.

How to Reproduce?

  1. Download reproducer from
    2021-10-26_restclient-reactive-multipart-response.zip
  2. Start quarkus with ./gradlew quarkusDev
  3. Call GET localhost:8080/hello/multipart

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@andreas-eberle andreas-eberle added the kind/bug Something isn't working label Oct 26, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 26, 2021

/cc @FroMage, @geoand, @stuartwdouglas

@geoand geoand added kind/enhancement New feature or request and removed kind/bug Something isn't working labels Oct 26, 2021
@geoand geoand changed the title Resteasy Reactive does not support MultiPart Form result Support MultiPart form result in Resteasy Reactive Oct 26, 2021
@geoand
Copy link
Contributor

geoand commented Oct 26, 2021

@Sgitario FYI

@andreas-eberle
Copy link
Contributor Author

Hi @Sgitario! Thanks for the implementation. Does this implementation also apply to the resteasy reactive client?

@Sgitario
Copy link
Contributor

Sgitario commented Nov 8, 2021

Hi @Sgitario! Thanks for the implementation. Does this implementation also apply to the resteasy reactive client?

No, the reactive rest client does not support multipart formdata yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rest kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants