Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL guide simplifications #17827

Closed
FroMage opened this issue Jun 10, 2021 · 3 comments · Fixed by #17847
Closed

GraphQL guide simplifications #17827

FroMage opened this issue Jun 10, 2021 · 3 comments · Fixed by #17847

Comments

@FroMage
Copy link
Member

FroMage commented Jun 10, 2021

Following the GraphQL guide I noticed that we're:

  • Showing some large Film and Hero DTOs using lots of “dumb” accessors, when replacing them with public fields would work just as well and make the docs shorter and easier to read.
  • Showing @Name("filmId") when it's actually optional and we could use the parameter name, inducing me to falsly believe this was required.
  • I'm told I need to use @Inject Context by https://quarkus.io/guides/smallrye-graphql#context when trying to add it as a query method parameter appeared to Just Work.

Perhaps we can simplify the guide around these topics?

@quarkus-bot
Copy link

quarkus-bot bot commented Jun 10, 2021

/cc @jmartisk, @phillip-kruger

@phillip-kruger
Copy link
Member

Sounds good. I'll fix a.s.a.p

@FroMage
Copy link
Member Author

FroMage commented Jun 10, 2021

Thanks a lot! And also congrats on getting all those things right: they just worked when I tried them out, even though they were not documented in the guide :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants