Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry OTLP Exporter and Default Parameters Customizer #17640

Closed
luneo7 opened this issue Jun 2, 2021 · 1 comment
Closed

OpenTelemetry OTLP Exporter and Default Parameters Customizer #17640

luneo7 opened this issue Jun 2, 2021 · 1 comment
Labels
area/tracing kind/enhancement New feature or request
Milestone

Comments

@luneo7
Copy link
Contributor

luneo7 commented Jun 2, 2021

Description

When trying to use OpenTelemetry with AWS Otel (https://aws-otel.github.io/) I saw that right now the ContextPropagators are fixed to W3C (which doesn't work with AWS X-Ray), there is no possibility to change the Id Generator in the SdkTracerProviderBuilder (to work with AWS Otel we need to set it to AWS Id Generator), and also no way to change the append info to the Resource (AWS also has extension to set ECS Resource info for instance).

It would be good to have a way to set those and also to have the OTLP exporter so we can work with other OpenTelemetry distributions.

Implementation ideas

  1. Since the ContextPropagators are coded distinctively from each other (a few use service loader, and those that don't they have different static methods to fetch the propagator), the most feasible way is to use a Producer with DefaultBean that produces the W3C propagator, and if desired we can use an alternate one to change the propagator.
  2. Probably use a Producer with DefaultBean that produces the random Id generator default one, and if people want they can also use an alternate producer to change it.
  3. Also probably use a Producer with DefaultBean that produces a Resource (empty one) that people can use an alternate producer to change it, and in the recorder that resource is merged last.
@luneo7 luneo7 added the kind/enhancement New feature or request label Jun 2, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 2, 2021

/cc @kenfinnigan

@kenfinnigan kenfinnigan added this to the 2.1 - main milestone Jun 17, 2021
@kenfinnigan kenfinnigan changed the title OpenTelemetry OTLP Exporter and Default Paramters Customizer OpenTelemetry OTLP Exporter and Default Parameters Customizer Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tracing kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants