Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed OidcClients should throw ISE in its methods and OidcClients should ignore close IO Exceptions #16472

Closed
sberyozkin opened this issue Apr 13, 2021 · 1 comment · Fixed by #17932
Closed

Closed OidcClients should throw ISE in its methods and OidcClients should ignore close IO Exceptions #16472

sberyozkin opened this issue Apr 13, 2021 · 1 comment · Fixed by #17932
Labels
area/oidc kind/enhancement New feature or request
Milestone
2.0.0.Final

Comments

@sberyozkin
Copy link
Member

Description

Closed OidcClient should report ISE in its getTokens/refreshTokens method, while OidcClients should just ignore all close related exceptions - as the individual OidcClient (s) can be independently injected hence leading to redundant close requests

CC @fwippe
@sberyozkin sberyozkin added the kind/enhancement New feature or request label Apr 13, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 13, 2021

/cc @pedroigor

@sberyozkin sberyozkin mentioned this issue Apr 13, 2021
Merged
@sberyozkin sberyozkin mentioned this issue Jun 15, 2021
Merged
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 16, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.0.Final Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/oidc kind/enhancement New feature or request
Projects
None yet
Milestone
2.0.0.Final
Development

Successfully merging a pull request may close this issue.

Update OidcClientImpl to throw ISE if the client is closed sberyozkin/quarkus
2 participants
@sberyozkin @gsmet