Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmallRye Metrics should respond with Accept All headers #15310

Closed
kenfinnigan opened this issue Feb 24, 2021 · 4 comments
Closed

SmallRye Metrics should respond with Accept All headers #15310

kenfinnigan opened this issue Feb 24, 2021 · 4 comments
Labels

Comments

@kenfinnigan
Copy link
Member

Describe the bug
Metrics are not returned when accessing /q/metrics

Expected behavior
If no Accept header is passed, ie. it means Accept All, then the metrics should be returned

Actual behavior
Currently, SmallRye Metrics returns a HTTP 406 if text/plain is not passed as an Accept header type.

@kenfinnigan kenfinnigan added kind/bug Something isn't working area/metrics labels Feb 24, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 24, 2021

@jmartisk
Copy link
Contributor

I'm not sure what you mean here - if I call simply curl localhost:8080/q/metrics without any headers, I get a Prometheus export by default. I get a 406 error only if I pass an Accept header with an unrecognised value.

@kenfinnigan
Copy link
Member Author

@ebullient added a test yesterday where we had an issue where the behavior you describe didn't happen.

I don't believe the test was adding any accept headers to the request

@ebullient
Copy link
Member

I'll double check. this also may not be something unique to smallrye metrics, as I have #15093 also. I'll poke so we can be more precise about where something might need to be adjusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants