Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus CLI should look in parent directories to find maven and gradle wrappers #11516

Closed
ia3andy opened this issue Aug 21, 2020 · 7 comments · Fixed by #20503
Closed

Quarkus CLI should look in parent directories to find maven and gradle wrappers #11516

ia3andy opened this issue Aug 21, 2020 · 7 comments · Fixed by #20503
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/gradle Gradle area/maven kind/enhancement New feature or request
Milestone

Comments

@ia3andy
Copy link
Contributor

ia3andy commented Aug 21, 2020

Description
In multi-module project you don't want to have the wrappers everywhere, right? at least I don't :), but also you want your command to work in sub-modules.

It would be nice if the new Quarkus CLI would look in parent folders to find mvnw or gradlew (and their windows equivalent) :)

@ia3andy ia3andy added the kind/enhancement New feature or request label Aug 21, 2020
@ia3andy
Copy link
Contributor Author

ia3andy commented Aug 21, 2020

cc @maxandersen @patriot1burke

@quarkusbot
Copy link

/cc @quarkusio/devtools, @glefloch
/cc @quarkusio/devtools

@ia3andy
Copy link
Contributor Author

ia3andy commented Aug 21, 2020

@patriot1burke btw I am adding those options to codestarts:

public CreateProject noExamples() {
        return noExamples(true);
    }

    public CreateProject noBuildToolWrapper(boolean value) {
        setValue(NO_BUILDTOOL_WRAPPER, value);
        return this;
    }

    public CreateProject noBuildToolWrapper() {
        return noBuildToolWrapper(true);
    }

    public CreateProject noDockerfiles(boolean value) {
        setValue(NO_DOCKERFILES, value);
        return this;
    }

@maxandersen
Copy link
Member

+1 on searching in parents for project and wrappers.

look at https://github.com/dansomething/mdub and gdub on how this search and exec for wrappers is done best without "surprises"

@maxandersen maxandersen added the area/cli Related to quarkus cli (not maven/gradle/etc.) label Aug 31, 2020
@TomasHofman
Copy link
Contributor

@maxandersen @ia3andy do you mind if I work on this, or has anybody started?

@maxandersen
Copy link
Member

@ebullient is rewamping the cli but would be interesting to have this. So +1 for me

@ebullient
Copy link
Member

Code looking for wrappers has been consolidated.. so this should be easier .. go for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/gradle Gradle area/maven kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants