Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up various kubernetes profiles config #300

Closed
edeandrea opened this issue Jun 9, 2023 · 4 comments · Fixed by #336
Closed

Clean up various kubernetes profiles config #300

edeandrea opened this issue Jun 9, 2023 · 4 comments · Fixed by #336
Assignees
Labels
enhancement New feature or request event-stats-service Event statistics service fights-service Fights service heroes-service Heroes service villains-service Villains service waiting-for/quarkus-release Waiting on something in Quarkus to be released

Comments

@edeandrea
Copy link
Collaborator

All the various kubernetes profile config within each application's configuration files could be made a whole bunch cleaner by using config syntax like %kubernetes,openshift,knative.property=value, which was introduced recently within Quarkus.

@edeandrea edeandrea added enhancement New feature or request fights-service Fights service villains-service Villains service heroes-service Heroes service event-stats-service Event statistics service labels Jun 9, 2023
@edeandrea edeandrea self-assigned this Jun 9, 2023
@edeandrea
Copy link
Collaborator Author

Actually @holly-cummins I'm not sure that the multiple-profiles thing actually helps clear this up at all because we're still only talking about the default profile...

quarkus.kubernetes.part-of=villains-service
quarkus.kubernetes.annotations."app.openshift.io/connects-to"=villains-db,otel-collector
quarkus.kubernetes.env.configmaps=${quarkus.application.name}-config
quarkus.kubernetes.env.secrets=${quarkus.application.name}-config-creds
quarkus.kubernetes.labels.app=${quarkus.application.name}
quarkus.kubernetes.labels.application=${quarkus.kubernetes.part-of}
quarkus.kubernetes.labels.system=quarkus-super-heroes

quarkus.openshift.part-of=${quarkus.kubernetes.part-of}
quarkus.openshift.annotations."app.openshift.io/connects-to"=villains-db,otel-collector
quarkus.openshift.env.configmaps=${quarkus.kubernetes.env.configmaps}
quarkus.openshift.env.secrets=${quarkus.kubernetes.env.secrets}
quarkus.openshift.labels.app=${quarkus.kubernetes.labels.app}
quarkus.openshift.labels.application=${quarkus.kubernetes.labels.application}
quarkus.openshift.labels.system=${quarkus.kubernetes.labels.system}

the problem is that there isn't (that we know of or is documented anywhere) any kind of inheritance between the quarkus.kubernetes.* namespace and others (quarkus.openshift.*, quarkus.minikube.*, quarkus.knative.*, etc)

@holly-cummins
Copy link
Collaborator

Oh, good point!

@edeandrea
Copy link
Collaborator Author

This will depend on quarkusio/quarkus#34487 and quarkusio/quarkus#34025

@edeandrea edeandrea added the waiting-for/quarkus-release Waiting on something in Quarkus to be released label Jul 31, 2023
@edeandrea
Copy link
Collaborator Author

Based on quarkusio/quarkus#34487 and quarkusio/quarkus#34025, the implementation of this will change a bit. We will define everything at the quarkus.kubernetes and then only add quarkus.openshift/minikube/knative/etc for things that need to be overridden, or that don't exist in quarkus.kubernetes.*.

edeandrea referenced this issue in edeandrea/quarkus-super-heroes Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request event-stats-service Event statistics service fights-service Fights service heroes-service Heroes service villains-service Villains service waiting-for/quarkus-release Waiting on something in Quarkus to be released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants