Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

Publish quarkus-openshift-test-suite library to maven repo #237

Open
llowinge opened this issue Mar 16, 2021 · 7 comments
Open

Publish quarkus-openshift-test-suite library to maven repo #237

llowinge opened this issue Mar 16, 2021 · 7 comments

Comments

@llowinge
Copy link

Camel Quarkus would like to consume your common/app-metadata library. Would be possible to do releases ?

@rsvoboda
Copy link
Member

We are working on product counterpart of Quarkus at the moment and thus we won't be able to work on this in foreseeable future.

Qaurkus QE team wants to invite you for closer cooperation on this project. We need to work closely on this topic as your (and your project/product) requirements and expectations can slightly differ comparing to our needs.

We are open to proposal from your side as you can help us to define the sharable parts of this testsuite.
One thing to be aware of is that this TS was not primarily designed as a framework.
On the other hand it was still quite a high priority to keep things properly separated.

@Ladicek
Copy link
Contributor

Ladicek commented Mar 16, 2021

For the record, when I forked the test framework from this test suite into Thorntail (https://github.com/thorntail/openshift-test/), I got rid of the app-metadata stuff (because there's obviously nothing like that in Thorntail) and replaced it with a more general mechanism: the test framework reads the openshift.yml file and discovers all the metadata from there. That has one consequence: there can be multiple applications in the file. (Similarly, I made the @CustomAppMetadata annotation repeatable.) The test framework treats the case of a single application in a special way (e.g. if there's single application, RestAssured is configured to point to it), but it also allows working with multiple easily.

@rsvoboda
Copy link
Member

So you are expecting that openshift.yml is properly generated. I know there are some issues with openshift.yml here and there, but the main properties we care about are imho stable.

Benefit of app-metadata module to me is that it's nice example of custom extension and it helps us to reveal issues in this are, mainly product dependency issue. So not convinced we should get rid of it.

About multiple applications in the file - you have handcrafted openshift.yml file? of there is some support for it as part of Thorntail, or even in Dekorate?

@rsvoboda
Copy link
Member

@Ladicek
Copy link
Contributor

Ladicek commented Mar 16, 2021

So you are expecting that openshift.yml is properly generated. I know there are some issues with openshift.yml here and there, but the main properties we care about are imho stable.

Indeed I do. I think we assume the same in this test suite as well, at least to a certain degree.

Benefit of app-metadata module to me is that it's nice example of custom extension and it helps us to reveal issues in this are, mainly product dependency issue. So not convinced we should get rid of it.

I totally agree it's a nice example of an external extension, but I'm not sure if that's the purpose of this test suite. But, yea, I agree that custom extensions need to be tested in one way or another, and I don't mind app-metadata being the canary in the coal mine for now :-)

About multiple applications in the file - you have handcrafted openshift.yml file? of there is some support for it as part of Thorntail, or even in Dekorate?

That is supported in Fabric8 Maven plugin, JKube, and Quarkus as well (src/main/kubernetes for example). Not sure about Dekorate specifically.

@llowinge
Copy link
Author

I like the idea about removing app-metadata and having it automated based on openshift.yml but with possibility of @ CustomAppMetadata`.

@rsvoboda
Copy link
Member

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants