Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token path #14

Open
piergiorgioladisa opened this issue May 23, 2024 · 1 comment
Open

Token path #14

piergiorgioladisa opened this issue May 23, 2024 · 1 comment

Comments

@piergiorgioladisa
Copy link

Salut,

first of all great tool, I'm loving it.

I was just testing it and noticed that it failed to retrieve the ServiceAccount token from a privileged pod. I guess that the source of the issue is that in the token.go file, the tokenPath is set as /run/secrets/kubernetes.io/serviceaccount instead of /var/run/secrets/kubernetes.io/serviceaccount:

tokenPath = "/run/secrets/kubernetes.io/serviceaccount"

@mtardy
Copy link
Collaborator

mtardy commented May 23, 2024

Hey, I'm very glad that you love it and use it!

Honestly, it's been 2 years since kdigger received any support since I left Quarkslab almost a couple of years ago now. But they have been nice enough to keep me as a maintainer on this repo. Aside from telling my life story, what it means is that if you are motivated enough to create a PR, I can still take a look and merge it :)!

You can correct the path or add two of them to retry in case it doesn't exist, I took a look into this and it seems /run is the new /var/run. So, /var/run is generally symlinked to /run (see). So I think it makes sense to search for /run first but searching for /var/run just after if it fails would make sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants