Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #711: Update Solid Start detection #712

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Fix #711: Update Solid Start detection #712

merged 1 commit into from
Jul 7, 2024

Conversation

melloware
Copy link
Contributor

Fix #711: Update Solid Start detection

@melloware melloware added the enhancement New feature or request label Jul 7, 2024
@melloware melloware added this to the 2.4.2 milestone Jul 7, 2024
@melloware melloware mentioned this pull request Jul 7, 2024
Closed
@melloware melloware merged commit ab4ec47 into quarkiverse:main Jul 7, 2024
2 checks passed
@melloware melloware deleted the solid-vinxi branch July 7, 2024 20:43
apatrida
apatrida reviewed Jul 9, 2024
View reviewed changes
deployment/src/main/java/io/quarkiverse/quinoa/deployment/framework/FrameworkType.java
@@ -41,7 +41,8 @@ public enum FrameworkType {
VUE_LEGACY(Set.of("vue-cli-service serve"), generic("dist", "serve", 3000)),
VITE(Set.of("vite"), generic("dist", "dev", 5173)),
FARM(Set.of("farm"), generic("dist", "dev", 9000)),
SOLID_START(Set.of("solid-start dev", "vinxi dev"), generic("dist", "dev", 3000)),
SOLID_START_LEGACY(Set.of("solid-start dev"), generic("dist", "dev", 3000)),
SOLID_START(Set.of("vinxi dev"), generic("output", "dev", 3000)),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is .output not output

@apatrida
Copy link

apatrida commented Jul 9, 2024

small error here. The output dir lf a build command is .output not output

Vinxi creates .vinxi directory first, and stages new files there as well as server code splitting, then builds .output depending on the server plugin being used the final verison for that server there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apatrida apatrida apatrida left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.4.2
Development

Successfully merging this pull request may close these issues.

SolidJS: update docs for configuration
2 participants
@melloware @apatrida