Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPA: Resuming on 404 #665

Closed
ThoSap opened this issue Apr 5, 2024 · 4 comments
Closed

SPA: Resuming on 404 #665

ThoSap opened this issue Apr 5, 2024 · 4 comments
Labels
feature

Comments

@ThoSap
Copy link

ThoSap commented Apr 5, 2024

Just as a heads up, could Quinoa be refactored to use
quarkusio/quarkus#38852
when
quarkus.quinoa.enable-spa-routing is enabled?
@ThoSap ThoSap added the feature label Apr 5, 2024
@ia3andy
Copy link
Collaborator

ia3andy commented Apr 5, 2024

It's already the case, it's done using BuildItems

@ia3andy
Copy link
Collaborator

ia3andy commented Apr 5, 2024

https://github.com/quarkiverse/quarkus-quinoa/blob/main/deployment/src/main/java/io/quarkiverse/quinoa/deployment/QuinoaProcessor.java#L265

@ThoSap
Copy link
Author

ThoSap commented Apr 5, 2024

All good then 😋
I just thought that Quinoa could maybe use the refactoring of this PR which is for Quarkus REST (formerly Quarkus RESTEasy Reactive).

@melloware
Copy link
Contributor

Closing this as I don't think there is any action for us. Will reopen if anyone disagrees

@melloware melloware closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ia3andy @melloware @ThoSap