-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change mailpit URL exposed in Dev UI? #79
Comments
@ggrebert do you know if the above request is a limitation of TestContainers or Quarkus? |
It's not a TestContainer limitation. |
Could it be something similar to quarkusio/quarkus#42065 ? (I haven’t looked at the issue, just connecting the dots on my phone…) |
@gsmet that does look like its the solution! |
The shared network is used for the communications between containers. |
Nice! Would this change make #82 irrelevant? Or do you think having a way to configure a fixed port mapping is still a relevant use case? |
@edeandrea honestly i never know someone's use case so having it configurable is fine with me. I am sure someone else will ask for it down the road because they have 8025 in use by some other app or something! |
Agree. |
With this 'proxy approach', we can envisage more quarkiverse extensions like |
I made a few minor fixes: #85 |
1.2.0 is in Maven Central @edeandrea if you want to give it a spin? |
I'll give it a spin in a little bit! Just sitting down to start my day! |
Excellent!!! |
Thank you both for the quick turnaround! |
I notice in the Dev UI that when clicking the Mailpit UI link the URL brings you to a
127.0.0.1
URL.Is it possible to change the host name in the URL? In cloud-based IDEs (like Eclipse Che, Gitpod, etc), the URL in the browser can't be
127.0.0.1
/localhost
. It needs to be a URL where the port can be mapped to the URL of the workspace.The text was updated successfully, but these errors were encountered: