Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @Inject-ing clients without @CXFClient at least in unambiguous cases. #961

Open
ppalaga opened this issue Aug 15, 2023 · 2 comments

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Aug 15, 2023

Follows up #952 (comment)

Pure @Inject at least for the non-ambiguous cases sounds interesting though. [...] If the case is ambiguous, the extension should throw an exception (ideally at build time) advising the user to use @CXFClient. Contributions are welcome!

@amoscatelli
Copy link

amoscatelli commented Aug 16, 2023

I think this will lead to ambiguity problems between injecting the service impl and the SEI Proxy client.
To tell the truth, I still can't understand what's the sense in injecting the service impl.

I hope I am wrong.

@ppalaga
Copy link
Contributor Author

ppalaga commented Aug 16, 2023

That's a good point. If a user annotates his implementation class with @ApplicationScoped or similar, he may expect it to be passed to injection points having the SEI type. That would conflict with the client proxy also implementing the SEI. I wonder whether that conflict would not exist already with the present implementation. I guess a CDI Qualifier could be used to keep the two candidate beans apart. I need to try how it works with our current implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants