Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipeline: remove package-phase from populate-cache job #156

Closed
turing85 opened this issue Feb 11, 2023 · 3 comments · Fixed by #185
Closed

pipeline: remove package-phase from populate-cache job #156

turing85 opened this issue Feb 11, 2023 · 3 comments · Fixed by #185
Assignees
@louisa-fr
Labels
maintenance quarkus-3
Milestone
Quarkus 3.0.0

Comments

@turing85
Copy link
Contributor

turing85 commented Feb 11, 2023 •
edited
Loading

We added the package-phase, as well as some configuration (--define skipTests and --define no-format) here to work around a bug in the target go-offline of the quarkus-maven-plugin. PR quarkusio/quarkus#31092 resolves the bug and is scheduled for realease in version 3.0.

When quarkus 3 is released, we should revert those changes and remove the TODO.
@turing85
Copy link
Contributor Author

turing85 commented Mar 8, 2023 •
edited
Loading

The merge request in quarkus is released with 3.0.0.Alpha5. Thus, this issue is ready for development.

@turing85

This comment was marked as outdated.

Sign in to view
@louisa-fr
Copy link

I would like to work on this, too :) (Marco knows about it)

@louisa-fr louisa-fr mentioned this issue Mar 12, 2023
Merged
@turing85 turing85 linked a pull request Mar 12, 2023 that will close this issue
#156: remove package-phase from populate-cache-job #185
Merged
@turing85 turing85 added this to the Quarkus 3.0.0 milestone Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@louisa-fr louisa-fr

Labels
maintenance quarkus-3
Projects
None yet
Milestone
Quarkus 3.0.0
Development

Successfully merging a pull request may close this issue.

#156: remove package-phase from populate-cache-job louisa-fr/quarkus-artemis
2 participants
@turing85 @louisa-fr