-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically alphabetise source file in an async job #161
Comments
That's a good idea |
Reminded of this by #171 (comment) :) |
Instead of doing it in an async job, wouldn't be better if it performed this validation when the PR is opened? |
I think something that happened when the PR was opened could mark the PR red, but not fix the problem. So that would be a better experience for us, and faster feedback for extension authors, but we'd still be knocking their contributions back and asking them to manually do what a computer could do. On the other hand, it avoids all the scariness of automated changes, and it would be easy to do. |
https://github.com/orgs/community/discussions/24945 seems to imply that commits can be added to someone else's PR, and provides an action for it. So maybe it is possible, in which case we should ignore all my comments above. :) ... although https://github.com/orgs/community/discussions/32032 seems to be confirming it's not possible. So maybe not. |
IIRC, you can push to a PR only if the PR was created from a branch of the repository itself. You won't be able to push to a forked repo. And given you cannot have secrets in a PR, you cannot push with a PAT. |
We often have to give feedback on PRs asking people to put things in alphabetical order. See, for example, #160 (comment).
We could reduce friction for contributors and effort for us if we had a CI job to sort out the order and commit back corrections.
The text was updated successfully, but these errors were encountered: