Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InvertRealNumber bloq #1151

Merged
merged 5 commits into from
Jul 19, 2024
Merged

Add InvertRealNumber bloq #1151

merged 5 commits into from
Jul 19, 2024

Conversation

charlesyuan314
Copy link
Contributor

Cost out the arithmetic operation of inverting a real number >= 1. Uses Newton-Raphson iteration as specified by this reference.

This bloq can be combined with inverse square root to compute the square root of a number.

@charlesyuan314 charlesyuan314 requested a review from fdmalone July 17, 2024 21:58
Copy link
Collaborator

@fdmalone fdmalone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small questions / comments. Looking good!

@charlesyuan314 charlesyuan314 requested a review from fdmalone July 18, 2024 01:04
@charlesyuan314
Copy link
Contributor Author

@fdmalone with the changes, do you think this is ready to merge?

@fdmalone fdmalone enabled auto-merge (squash) July 19, 2024 06:43
@fdmalone fdmalone disabled auto-merge July 19, 2024 06:43
@fdmalone fdmalone enabled auto-merge (squash) July 19, 2024 06:43
@fdmalone fdmalone merged commit a837d06 into quantumlib:main Jul 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants