ControlledAddOrSubtract Bloq
#1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anurudhp
force-pushed
the
2024/07/12-controlled-add-sub
branch
from
c4876ad to
f4ffb02
Compare
Merged
anurudhp
force-pushed
the
2024/07/12-controlled-add-sub
branch
from
4830b4d to
6f501e1
Compare
mpharrigan
reviewed
Jul 18, 2024
anurudhp
force-pushed
the
2024/07/12-controlled-add-sub
branch
from
3625e6d to
96ca306
Compare
mpharrigan
reviewed
Jul 22, 2024
Comment on lines
+533
to
+534
| ctrls, x = bb.add_t(bloq, ctrls=np.asarray(ctrl_soqs), **in_soqs) | ||
| return np.asarray(ctrls).tolist(), (x,) |
There was a problem hiding this comment.
was this a bug? is there a test that would have caught it?
actually: what's going on here? the conditions above exclude any situation in where there is more than one SoquetT being passed in. For this bloq, that one SoquetT is an array of soquets
There was a problem hiding this comment.
It fails on test_tensor:
for li in reg.all_idxs():
> idxed_soq = in_soq[li]
E IndexError: too many indices for array: array is 0-dimensional, but 1 were indexed
mpharrigan
reviewed
Jul 22, 2024
mpharrigan
reviewed
Jul 22, 2024
|
Some nits but LGTM, but I'll let @tanujkhattar take a final look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has half the T-cost of a controlled addition gate. Useful to perform an Rz rotation via addition into phase gradient, at half the cost of a ZPow.