CYGate #1115
Merged
CYGate #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanujkhattar
approved these changes
Jul 9, 2024
qualtran/bloqs/basic_gates/y_gate.py
Outdated
|
|
||
| @cached_property | ||
| def signature(self) -> 'Signature': | ||
| return Signature.build(ctrl=1, q=1) |
There was a problem hiding this comment.
Should we use ctrl and target instead of ctrl and q ? That's what the CNOT gate uses.
| np.testing.assert_allclose(YGate().tensor_contract(), cbloq.tensor_contract()) | ||
|
|
||
|
|
||
| def test_cy_adjoint(): |
There was a problem hiding this comment.
Please add a test for t_complexity(CYGate())
|
At long last, I have addressed the review comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the controlled Y gate
Basic gates #1109