Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please rename protobuf field "module" to "gate_module" #6743

Open
pavoljuhas opened this issue Sep 23, 2024 · 1 comment
Open

Please rename protobuf field "module" to "gate_module" #6743

pavoljuhas opened this issue Sep 23, 2024 · 1 comment
Assignees
@NoureldinYosri
Labels
kind/health For CI/testing/release process/refactoring/technical debt items triage/accepted there is consensus amongst maintainers that this is a real bug or a reasonable feature to add
Milestone
2025-T6: Code hea...

Comments

@pavoljuhas
Copy link
Collaborator

Description of the issue

Per internal proto checker, field name module introduced in #6212 is discouraged, because it overlaps with C++ keyword module.
Please rename to, e.g., gate_module.

Cirq version

1.5.0.dev at 2bbc3c4
@pavoljuhas pavoljuhas added the kind/health For CI/testing/release process/refactoring/technical debt items label Sep 23, 2024
@pavoljuhas
Copy link
Collaborator Author

cc @mhucka

@NoureldinYosri NoureldinYosri added the triage/accepted there is consensus amongst maintainers that this is a real bug or a reasonable feature to add label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NoureldinYosri NoureldinYosri

Labels
kind/health For CI/testing/release process/refactoring/technical debt items triage/accepted there is consensus amongst maintainers that this is a real bug or a reasonable feature to add
Projects
Cirq 2025 roadmap
Status: No status
Milestone
2025-T6: Code health and project main...
Development

No branches or pull requests
3 participants
@mhucka @pavoljuhas @NoureldinYosri