Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MacOS checks failing #5880

Closed
vtomole opened this issue Sep 20, 2022 · 9 comments · Fixed by #5882 or #5886
Closed

MacOS checks failing #5880

vtomole opened this issue Sep 20, 2022 · 9 comments · Fixed by #5882 or #5886
Labels
kind/health For CI/testing/release process/refactoring/technical debt items

Comments

@vtomole
Copy link
Collaborator

vtomole commented Sep 20, 2022

Started today. See https://github.com/quantumlib/Cirq/actions/runs/3092172859/jobs/5003479363
@vtomole vtomole added the kind/health For CI/testing/release process/refactoring/technical debt items label Sep 20, 2022
@vtomole vtomole mentioned this issue Sep 20, 2022
Merged
@pavoljuhas
Copy link
Collaborator 

fatal: unable to access 'https://github.com/tensorflow/docs/': The requested URL returned error: 429

Seems that the CI is getting rate-throttled by GitHub?

@vtomole
Copy link
Collaborator Author

vtomole commented Sep 20, 2022

@MarkDaoust @lamberta Is tensorflow-docs on Pypi? I can't find it.

@lamberta
Copy link
Contributor

@vtomole No, not on PyPi but you can pip install it from the Git repo, see https://github.com/tensorflow/docs/tree/master/tools/tensorflow_docs/tools

@vtomole
Copy link
Collaborator Author

vtomole commented Sep 20, 2022

you can pip install it from the Git repo,

@lamberta That's what our CI does now, but apparently Github might be rate throttling us. Hence this issue.

@vtomole
Copy link
Collaborator Author

vtomole commented Sep 20, 2022

fatal: unable to access 'https://github.com/tensorflow/docs/': The requested URL returned error: 429

@pavoljuhas
Copy link
Collaborator

I think we can install tensorflow_docs from its git archive tarball,
that should have lower demands than cloning a git repo.

Let me prepare a PR for that ...

@pavoljuhas pavoljuhas mentioned this issue Sep 20, 2022
Merged
pavoljuhas added a commit to pavoljuhas/Cirq that referenced this issue Sep 20, 2022
@pavoljuhas
Use GitHub tarball for tensorflow-docs dependency
51d7b34 
Avoid rate-throttling errors from too much cloning on GitHub.

Fix quantumlib#5880
CirqBot pushed a commit that referenced this issue Sep 21, 2022
@pavoljuhas
Use GitHub tarball for tensorflow-docs dependency (#5882)
e249959 
Avoid traffic throttling on GitHub due to too much cloning.

Fix #5880
@tanujkhattar
Copy link
Collaborator

I think using github tarball as a dependency is causing CI failures?

https://github.com/quantumlib/Cirq/actions/runs/3095026537/jobs/5009016923

@tanujkhattar tanujkhattar reopened this Sep 21, 2022
@vtomole vtomole mentioned this issue Sep 21, 2022
Merged
@vtomole
Copy link
Collaborator Author

vtomole commented Sep 21, 2022

An oversight on my review: We are attempting to upload tensorflow-docs as a dev requirement because the existing setup.py doesn't remove it. Filed #5886.

@vtomole
Copy link
Collaborator Author

vtomole commented Sep 21, 2022

Fixed https://github.com/quantumlib/Cirq/actions/runs/3099583511/jobs/5018890923

rht pushed a commit to rht/Cirq that referenced this issue May 1, 2023
@pavoljuhas @rht
Use GitHub tarball for tensorflow-docs dependency (quantumlib#5882)
0742acd 
Avoid traffic throttling on GitHub due to too much cloning.

Fix quantumlib#5880
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/health For CI/testing/release process/refactoring/technical debt items
Projects
None yet
Milestone
No milestone
4 participants
@lamberta @pavoljuhas @tanujkhattar @vtomole