Skip to content
This repository has been archived by the owner on Nov 10, 2020. It is now read-only.

__aiter__() doesn't await next_page() #14

Closed
txomon opened this issue Nov 15, 2016 · 2 comments
Closed

__aiter__() doesn't await next_page() #14

txomon opened this issue Nov 15, 2016 · 2 comments
Labels
aws bug test

Comments

@txomon
Copy link

txomon commented Nov 15, 2016 •
edited
Loading

I may be wrong, but shouldn't __aiter__() await next_page()?

pulsar-cloud/cloud/asyncbotocore/paginate.py

Line 89 in 28d7518

return self.next_page()

@lsbardel
Copy link
Member

You are right I think, that code is not covered by tests either.
This needs to be tested.

@lsbardel lsbardel added the aws label Nov 16, 2016
lsbardel referenced this issue Nov 17, 2016
@lsbardel
async iterator must wait for page. Added test for coverage and refact…
a53c79c 
…ored green iterator
@lsbardel
Copy link
Member

Tested and fixed it. Thanks for reporting

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
aws bug test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lsbardel @txomon