Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String literal data type is not compacted #118

Closed
gsvarovsky opened this issue Nov 19, 2020 · 2 comments
Closed

String literal data type is not compacted #118

gsvarovsky opened this issue Nov 19, 2020 · 2 comments

Comments

@gsvarovsky
Copy link
Contributor

https://github.com/beautifulinteractions/node-quadstore/blob/faf3cd5f694b329d0d486f07bbdd4dd835de7030/lib/serialization/import.ts#L19

The xsd.string data type is not subjected to compaction when using prefixes.

If it were compacted, it would still be subject to expansion in the current export module: https://github.com/beautifulinteractions/node-quadstore/blob/faf3cd5f694b329d0d486f07bbdd4dd835de7030/lib/serialization/export.ts#L14
@jacoscaz
Copy link
Collaborator

Ah, good catch. Will fix soon!

@jacoscaz
Copy link
Collaborator

Fixed this in 1400bbe, will release in either 7.1.0 or the next beta. Let me know if this is urgent for you and I'll release another beta right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacoscaz @gsvarovsky