Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI that include static frontend files when creating wheel package #26

Open
nulinspiratie opened this issue Mar 11, 2024 · 5 comments
Assignees
Labels

Comments

@nulinspiratie
Copy link
Contributor

We want to have a Github workflow that creates a wheel package that already includes static frontend files.
This Github workflow can also be combined to create a new release.

@nulinspiratie nulinspiratie changed the title Backend: Add CI that include static frontend files when creating wheel package Add CI that include static frontend files when creating wheel package Mar 11, 2024
@maxim-v4s
Copy link
Collaborator

maxim-v4s commented Mar 14, 2024

@nulinspiratie release can be created only based on tag.
There are 2 options:

  1. Make 2 different workflows:
    1. First workflow allows to manually build package on request (trigger workflow on Github Actions page).
    2. Second workflow creates release from pushed tag.
  2. Make only one workflow that creates tag and release on manual trigger.

In both cases it's needed to have token for release creation.

@nulinspiratie
Copy link
Contributor Author

I think option 1 makes the most sense, this way we're not forced to create a new release when we want to rebuild

@maxim-v4s
Copy link
Collaborator

In second case we also not forced.
It's possible to add flag that will enable release steps.

@nulinspiratie
Copy link
Contributor Author

So what do you mean by a manual trigger? Is it still a Github Action? Or a command-line call on the local PC?

@maxim-v4s
Copy link
Collaborator

I mean workflow_dispatch action trigger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants