-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quaqsim.architectures.resonator.py #11
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @AbdullahKazi500!
Several modifications are needed before merging this PR. Specifically:
- The filepath should be
quaqsim/architectures/resonator.py
. I noticed it was written confusingly in the issue so I've rectified it - The file contains a new class definition for
Transmon
, and two definitions forResonator
. It should instead only contain a single class definition for Resonator, and in turn theResonator
should be an optional attribute of the Transmon - The bottom of the file contains a
program()
definition. This should not be in the same file as the class definition. Instead, an example file that produces accurate results as described in the issue should be included elsewhere, either in the PR description, or preferably in a separateexamples
folder. - The example should include the necessary config structure that can be used to demonstrate resonator spectroscopy
Let me know if anything is unclear, happy to discuss further!
Can we ensure that the Hamiltonian matrices of the transmon and the resonator are appropriately combined when the resonator is coupled to the transmon? How does the method incorporate the resonator's Hamiltonian into the transmon's Hamiltonian matrix? |
Looking at the code, there's indeed no coupling term yet. It would make sense to use the Jaynes-Cummings Hamiltonian for this: https://en.wikipedia.org/wiki/Jaynes%E2%80%93Cummings_model |
|
The results should show qubit-resonator coupling, e.g. by having the resonator frequency depend on the qubit frequency. This is not apparent from your results yet |
Hi assad how should the frequency be like |
Hey Abdullah, the resonance frequency should match that of the resonator's ground-to-first-excited-state when coupled to a transmon. The Jaynes-Cummings model would be appropriate in this case. |
Can I predict the splitting of energy levels (Rabi splitting) using the Jaynes-Cummings model? |
@AbdullahKazi500 yes you can, the Jaynes-Cummings model is one of a resonator coupled to a transmon, so the resonator's frequency depends on that of the transmon. You can find each by calculating the eigenenergies of the Hamiltonian |
thanks will have a look |
will fix #1