Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quaqsim.architectures.resonator.py #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AbdullahKazi500
Copy link

will fix #1

@CLAassistant
Copy link

CLAassistant commented Jun 7, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@nulinspiratie nulinspiratie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @AbdullahKazi500!

Several modifications are needed before merging this PR. Specifically:

  • The filepath should be quaqsim/architectures/resonator.py. I noticed it was written confusingly in the issue so I've rectified it
  • The file contains a new class definition for Transmon, and two definitions for Resonator. It should instead only contain a single class definition for Resonator, and in turn the Resonator should be an optional attribute of the Transmon
  • The bottom of the file contains a program() definition. This should not be in the same file as the class definition. Instead, an example file that produces accurate results as described in the issue should be included elsewhere, either in the PR description, or preferably in a separate examples folder.
  • The example should include the necessary config structure that can be used to demonstrate resonator spectroscopy

Let me know if anything is unclear, happy to discuss further!

@AbdullahKazi500
Copy link
Author

Thanks for the contribution @AbdullahKazi500!

Several modifications are needed before merging this PR. Specifically:

  • The filepath should be quaqsim/architectures/resonator.py. I noticed it was written confusingly in the issue so I've rectified it
  • The file contains a new class definition for Transmon, and two definitions for Resonator. It should instead only contain a single class definition for Resonator, and in turn the Resonator should be an optional attribute of the Transmon
  • The bottom of the file contains a program() definition. This should not be in the same file as the class definition. Instead, an example file that produces accurate results as described in the issue should be included elsewhere, either in the PR description, or preferably in a separate examples folder.
  • The example should include the necessary config structure that can be used to demonstrate resonator spectroscopy

Let me know if anything is unclear, happy to discuss further!

Can we ensure that the Hamiltonian matrices of the transmon and the resonator are appropriately combined when the resonator is coupled to the transmon? How does the method incorporate the resonator's Hamiltonian into the transmon's Hamiltonian matrix?

@nulinspiratie
Copy link
Contributor

Looking at the code, there's indeed no coupling term yet. It would make sense to use the Jaynes-Cummings Hamiltonian for this: https://en.wikipedia.org/wiki/Jaynes%E2%80%93Cummings_model
A consequence of this is that we need a combined transmon+resonator wave function, an example of how this is implemented can be found in QuTiP: https://qutip.readthedocs.io/en/qutip-5.0.x/guide/guide-tensor.html#a-two-level-system-coupled-to-a-cavity-the-jaynes-cummings-model

@AbdullahKazi500
Copy link
Author

Looking at the code, there's indeed no coupling term yet. It would make sense to use the Jaynes-Cummings Hamiltonian for this: https://en.wikipedia.org/wiki/Jaynes%E2%80%93Cummings_model A consequence of this is that we need a combined transmon+resonator wave function, an example of how this is implemented can be found in QuTiP: https://qutip.readthedocs.io/en/qutip-5.0.x/guide/guide-tensor.html#a-two-level-system-coupled-to-a-cavity-the-jaynes-cummings-model

lorentzian
getting something like this

@nulinspiratie
Copy link
Contributor

The results should show qubit-resonator coupling, e.g. by having the resonator frequency depend on the qubit frequency. This is not apparent from your results yet

@AbdullahKazi500
Copy link
Author

The results should show qubit-resonator coupling, e.g. by having the resonator frequency depend on the qubit frequency. This is not apparent from your results yet

Hi assad how should the frequency be like

@nulinspiratie
Copy link
Contributor

Hey Abdullah, the resonance frequency should match that of the resonator's ground-to-first-excited-state when coupled to a transmon. The Jaynes-Cummings model would be appropriate in this case.

@AbdullahKazi500
Copy link
Author

Hey Abdullah, the resonance frequency should match that of the resonator's ground-to-first-excited-state when coupled to a transmon. The Jaynes-Cummings model would be appropriate in this case.

Can I predict the splitting of energy levels (Rabi splitting) using the Jaynes-Cummings model?

@nulinspiratie
Copy link
Contributor

@AbdullahKazi500 yes you can, the Jaynes-Cummings model is one of a resonator coupled to a transmon, so the resonator's frequency depends on that of the transmon. You can find each by calculating the eigenenergies of the Hamiltonian

@AbdullahKazi500
Copy link
Author

@AbdullahKazi500 yes you can, the Jaynes-Cummings model is one of a resonator coupled to a transmon, so the resonator's frequency depends on that of the transmon. You can find each by calculating the eigenenergies of the Hamiltonian

thanks will have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add resonator that can be coupled to a transmon
3 participants