Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low results #10

Open
FraLotito opened this issue Aug 16, 2019 · 4 comments
Open

Low results #10

FraLotito opened this issue Aug 16, 2019 · 4 comments

Comments

@FraLotito
Copy link

Hi!

Why are the results so low with respect to the paper? Have you found an explanation?

Thanks

@zhuyijie88
Copy link

+1, the reported results are worse than these in the paper by a large margin.

@aphalak
Copy link

aphalak commented Aug 27, 2019

I think the model implementation is incorrect for the voting module layers.
In the paper, the weights are shared such that each seed feature is passed forward separately, so there should be a for loop of forward passes per seed feature, whereas in the implementation here, there is a single forward pass over the FullyConnected layer.

@qq456cvb
Copy link
Owner

qq456cvb commented Jan 13, 2020

@aphalak Though each seed feature is passed forward separately in the paper, the weights are shared so we could batch them together and do a single forward. That is not the reason of low results. I am also figuring out what is happening and it is some what related to Issue #9 . Since all computations are gathered in the graph, when there is no "positive" vote, the code continues in vain, making training inefficient.

@619862306
Copy link

Could you please give me a copy of the script file of tf_nms3d_compile.sh?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants