From 757b10e3378cbf06b4369d3ec54f576f27dbcc8c Mon Sep 17 00:00:00 2001 From: Duncan Sutherland Date: Fri, 21 Jul 2023 14:50:19 +0100 Subject: [PATCH 1/2] modernize `dactyl_minidox` --- keyboards/handwired/dactyl_minidox/config.h | 8 +++++--- keyboards/handwired/dactyl_minidox/info.json | 8 ++++++++ keyboards/handwired/dactyl_minidox/rules.mk | 13 +------------ 3 files changed, 14 insertions(+), 15 deletions(-) diff --git a/keyboards/handwired/dactyl_minidox/config.h b/keyboards/handwired/dactyl_minidox/config.h index d84e9b644020..c5046d0fd31f 100644 --- a/keyboards/handwired/dactyl_minidox/config.h +++ b/keyboards/handwired/dactyl_minidox/config.h @@ -17,9 +17,11 @@ along with this program. If not, see . #pragma once // WS2812 RGB LED strip input and number of LEDs -#define RGB_MATRIX_LED_COUNT 36 -#define RGB_MATRIX_SPLIT { 18, 18 } -#define RGB_MATRIX_CENTER { 133, 54 } +#ifdef RBG_MATRIX_ENABLE +# define RGB_MATRIX_LED_COUNT 36 +# define RGB_MATRIX_SPLIT { 18, 18 } +# define RGB_MATRIX_CENTER { 133, 54 } +#endif /* Mechanical locking support. Use KC_LCAP, KC_LNUM or KC_LSCR instead in keymap */ #undef LOCKING_SUPPORT_ENABLE diff --git a/keyboards/handwired/dactyl_minidox/info.json b/keyboards/handwired/dactyl_minidox/info.json index 0a1c6a56bbcd..5dbe2dd19c50 100644 --- a/keyboards/handwired/dactyl_minidox/info.json +++ b/keyboards/handwired/dactyl_minidox/info.json @@ -8,6 +8,14 @@ "pid": "0x3536", "device_version": "0.0.3" }, + "features": { + "bootmagic": true, + "console": false, + "command": false, + "extrakey": true, + "mousekey": true, + "nkro": true + }, "ws2812": { "pin": "D3" }, diff --git a/keyboards/handwired/dactyl_minidox/rules.mk b/keyboards/handwired/dactyl_minidox/rules.mk index e22ac7f3ffcf..6e7633bfe015 100644 --- a/keyboards/handwired/dactyl_minidox/rules.mk +++ b/keyboards/handwired/dactyl_minidox/rules.mk @@ -1,12 +1 @@ -# Build Options -# change yes to no to disable -# -BOOTMAGIC_ENABLE = yes # Enable Bootmagic Lite -MOUSEKEY_ENABLE = yes # Mouse keys -EXTRAKEY_ENABLE = yes # Audio control and System control -CONSOLE_ENABLE = no # Console for debug -COMMAND_ENABLE = no # Commands for debug and configuration -NKRO_ENABLE = yes # Enable N-Key Rollover -BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality -RGBLIGHT_ENABLE = no # Enable keyboard RGB underglow -# AUDIO_ENABLE = yes # Audio output +# This file intentionally left blank From 645c9cc396fe1a8af2da9e0de741e9ab304b27f1 Mon Sep 17 00:00:00 2001 From: Duncan Sutherland Date: Fri, 28 Jul 2023 09:55:10 +0100 Subject: [PATCH 2/2] Update config.h revert RGB_MATRIX conditional --- keyboards/handwired/dactyl_minidox/config.h | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/keyboards/handwired/dactyl_minidox/config.h b/keyboards/handwired/dactyl_minidox/config.h index c5046d0fd31f..d84e9b644020 100644 --- a/keyboards/handwired/dactyl_minidox/config.h +++ b/keyboards/handwired/dactyl_minidox/config.h @@ -17,11 +17,9 @@ along with this program. If not, see . #pragma once // WS2812 RGB LED strip input and number of LEDs -#ifdef RBG_MATRIX_ENABLE -# define RGB_MATRIX_LED_COUNT 36 -# define RGB_MATRIX_SPLIT { 18, 18 } -# define RGB_MATRIX_CENTER { 133, 54 } -#endif +#define RGB_MATRIX_LED_COUNT 36 +#define RGB_MATRIX_SPLIT { 18, 18 } +#define RGB_MATRIX_CENTER { 133, 54 } /* Mechanical locking support. Use KC_LCAP, KC_LNUM or KC_LSCR instead in keymap */ #undef LOCKING_SUPPORT_ENABLE