Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimum compatible milc #13135

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Bump minimum compatible milc #13135

merged 1 commit into from
Jun 7, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jun 7, 2021 •
edited
Loading

Description

This should align with the changes required within #13046, and allow it to error out slightly gracefully.

Could also be 1.4.0, per clueboard/milc/pull/28 which introduced the change?

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the cli qmk cli command label Jun 7, 2021
@zvecr zvecr merged commit e0acd3e into master Jun 7, 2021
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@zvecr @HokieGeek
Update requirements.txt (qmk#13135)
8410d46
@fauxpark fauxpark deleted the zvecr-patch-1 branch August 3, 2021 10:18
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
@zvecr @wox
Update requirements.txt (qmk#13135)
aa5a19e
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@zvecr @nhongooi
Update requirements.txt (qmk#13135)
f2f20f4
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr
Update requirements.txt (qmk#13135)
11adb5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skullydazed skullydazed skullydazed approved these changes

Assignees
No one assigned
Labels
cli qmk cli command
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @skullydazed