-
-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Barleycorn #10118
Barleycorn #10118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, is this one PCB that supports both ANSI and ISO layouts, or are there two PCBs, one ANSI and one ISO?
Co-authored-by: Nick Brassel <[email protected]>
Co-authored-by: James Young <[email protected]>
Co-authored-by: Nick Brassel <[email protected]>
Co-authored-by: James Young <[email protected]>
Co-authored-by: James Young <[email protected]>
Co-authored-by: James Young <[email protected]>
Co-authored-by: James Young <[email protected]>
Co-authored-by: James Young <[email protected]>
Co-authored-by: James Young <[email protected]>
@noroadsleft Thanks for the review, it supports both ANSI and ISO. Also numpad is variable Also done with all the requested changes:) |
Co-authored-by: James Young <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
@drashna Can you explain QUANTUM_LIB_SRC quickly for future reference?:) |
Absolutely. Or at least, to the best of my ability. @mtei would be the best one to answer that, since they're the one that added it initially. For both Additionally, right now, it also prevents it from being optimized by LTO, which can cause timing and other unexpected issues (such as being optimized out). So, for stuff like i2c_master, and serial.c, you'd want to use one of these. Also, it's something that would be best to document this, but I think that mtei has a PR that changes things a bit, and add documentation. |
Cool, really good! yea documentation would be amazing:) |
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Ryan <[email protected]>
Indeed just get unnecessarily complicated for all the options... |
Co-authored-by: Drashna Jaelre <[email protected]>
@fauxpark #yourwishismycommand ?! anything else? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me otherwise.
Co-authored-by: James Young <[email protected]>
I suppose we did great now?:) |
Thanks! |
* Initial commit * Barleycorn rename * Update readme.md * PR checklist fixes * Update info.json * Update keyboards/barleycorn/rules.mk * Update keyboards/barleycorn/config.h * Update keyboards/barleycorn/rules.mk * Update keyboards/barleycorn/config.h * Update keyboards/barleycorn/info.json * Update keyboards/barleycorn/info.json * Update keyboards/barleycorn/readme.md * Update keyboards/barleycorn/rules.mk * Update keyboards/barleycorn/rules.mk * PR review * Update keyboards/barleycorn/readme.md * Update keyboards/barleycorn/rules.mk * Update keyboards/barleycorn/keymaps/default/readme.md * Update keyboards/barleycorn/keymaps/iso/readme.md * Update keyboards/barleycorn/rules.mk * Update keyboards/barleycorn/readme.md * Update keyboards/barleycorn/rules.mk * Update keyboards/barleycorn/matrix.c * Update keyboards/barleycorn/barleycorn.c * added ansi/iso keymaps! * Update keyboards/barleycorn/info.json
Description
Adding Ginghams big brother:)
Types of Changes
Issues Fixed or Closed by This PR
Checklist