Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New handwired keyboard - split ortho. #9959

Closed
FilipParyz opened this issue Aug 7, 2020 · 4 comments
Closed

New handwired keyboard - split ortho. #9959

FilipParyz opened this issue Aug 7, 2020 · 4 comments

Comments

@FilipParyz
Copy link
Contributor

I'd like to add my handwired keyboard to the mix of keyboards in the qmk.
Finished keyboard (soldered, programmed, working) can be seen on this imgur post: https://imgur.com/a/9UyvhUZ
It comes with a simple default keymap, it's a split ortho, two simetrical sides with 5x6 grid with 2u keycaps under thumbs. Very simple layout. I was originally inspired by Preonic ortho.
I've made my own version (handwired) of Preonic years ago, but didn't push it to the QMK. Now I want to fix my mistake by uploading a new keyboard!

I forked qmk and I'm working on that keyboard on branch paryzSplit56. It's working well, I may just add RGB underglow to it.
When I'm finished, should I merge that branch to my own master, then to qmk, or from my branch to qmk?

@str-dst
Copy link
Contributor

str-dst commented Aug 7, 2020

you can just create a pullrequest directly from your branch to the qmk master.

you won't be able to merge it yourself though. you have to go through the standard review process for that.

@FilipParyz
Copy link
Contributor Author

Oh no, I meant a PullRequest, I just wasn't sure if I need to merge to master on my side. Thanks for clarification :)

@stale
Copy link

stale bot commented Nov 5, 2020

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs.
For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

@stale stale bot added the stale Issues or pull requests that have become inactive without resolution. label Nov 5, 2020
@FilipParyz
Copy link
Contributor Author

Oh, @kb-elmo I've added my keyboard to the QMK :D
This PR was mine. Thanks for your help :)

@stale stale bot removed the stale Issues or pull requests that have become inactive without resolution. label Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants