Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong Mod Tap link in documentation for One Shot Keys #9321

Closed
mcp292 opened this issue Jun 6, 2020 · 3 comments
Closed

Wrong Mod Tap link in documentation for One Shot Keys #9321

mcp292 opened this issue Jun 6, 2020 · 3 comments
Labels
help wanted question

Comments

@mcp292
Copy link

mcp292 commented Jun 6, 2020

On this page in this sentence:

OSM(mod) - Momentarily hold down mod. You must use the MOD_* keycodes as shown in Mod Tap, not the KC_* codes.

Mod Tap links to: https://docs.qmk.fm/#/one_shot_keys?id=mod-tap
instead of: https://docs.qmk.fm/#/mod_tap
@rmwphd
Copy link
Contributor

rmwphd commented Jun 11, 2020

Looks like you're right. Want to submit a PR?

@mcp292
Copy link
Author

mcp292 commented Jun 11, 2020

I would but it might be a while until I can get to it.

@rmwphd rmwphd mentioned this issue Jun 11, 2020
Merged
13 tasks
@noroadsleft
Copy link
Member

Fixed by #9380.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rmwphd @noroadsleft @mcp292